Re: [PATCH v7 6/6] drm/amdgpu: add drm buddy support to amdgpu

Re: [PATCH v7 6/6] drm/amdgpu: add drm buddy support to amdgpu

[kernel test robot]

Hi Arunpravin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 5313fb2c779f74bc5083e9d3738d9b2c2ebe0aa4]

url:    https://github.com/0day-ci/linux/commits/Arunpravin/drm-move-the-buddy-allocator-from-i915-into-common-drm/20220109-222233
base:   5313fb2c779f74bc5083e9d3738d9b2c2ebe0aa4
config: riscv-randconfig-r042-20220109 (https://download.01.org/0day-ci/archive/20220110/202201101727.lThEC1FU-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f3a344d2125fa37e59bae1b0874442c650a19607)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/851f609d90fe77055b3c45169a1ddd469d5ae8ab
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Arunpravin/drm-move-the-buddy-allocator-from-i915-into-common-drm/20220109-222233
        git checkout 851f609d90fe77055b3c45169a1ddd469d5ae8ab
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_buddy.c:764:6: warning: no previous prototype for function 'drm_buddy_module_exit' [-Wmissing-prototypes]
   void drm_buddy_module_exit(void)
        ^
   drivers/gpu/drm/drm_buddy.c:764:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void drm_buddy_module_exit(void)
   ^
   static 
>> drivers/gpu/drm/drm_buddy.c:769:12: warning: no previous prototype for function 'drm_buddy_module_init' [-Wmissing-prototypes]
   int __init drm_buddy_module_init(void)
              ^
   drivers/gpu/drm/drm_buddy.c:769:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __init drm_buddy_module_init(void)
   ^
   static 
   2 warnings generated.


vim +/drm_buddy_module_exit +764 drivers/gpu/drm/drm_buddy.c

47666a7da23e2e Arunpravin 2022-01-09  763  
47666a7da23e2e Arunpravin 2022-01-09 @764  void drm_buddy_module_exit(void)
47666a7da23e2e Arunpravin 2022-01-09  765  {
47666a7da23e2e Arunpravin 2022-01-09  766  	kmem_cache_destroy(slab_blocks);
47666a7da23e2e Arunpravin 2022-01-09  767  }
47666a7da23e2e Arunpravin 2022-01-09  768  
47666a7da23e2e Arunpravin 2022-01-09 @769  int __init drm_buddy_module_init(void)
47666a7da23e2e Arunpravin 2022-01-09  770  {
47666a7da23e2e Arunpravin 2022-01-09  771  	slab_blocks = KMEM_CACHE(drm_buddy_block, 0);
47666a7da23e2e Arunpravin 2022-01-09  772  	if (!slab_blocks)
47666a7da23e2e Arunpravin 2022-01-09  773  		return -ENOMEM;
47666a7da23e2e Arunpravin 2022-01-09  774  
47666a7da23e2e Arunpravin 2022-01-09  775  	return 0;
47666a7da23e2e Arunpravin 2022-01-09  776  }
47666a7da23e2e Arunpravin 2022-01-09  777  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org