* [PATCH] btrfs: initialize variable cancel
@ 2022-01-21 13:45 trix
2022-01-21 15:40 ` Filipe Manana
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: trix @ 2022-01-21 13:45 UTC (permalink / raw)
To: clm, josef, dsterba, nathan, ndesaulniers, anand.jain
Cc: linux-btrfs, linux-kernel, llvm, Tom Rix
From: Tom Rix <trix@redhat.com>
Clang static analysis reports this problem
ioctl.c:3333:8: warning: 3rd function call argument is an
uninitialized value
ret = exclop_start_or_cancel_reloc(fs_info,
cancel is only set in one branch of an if-check and is
always used. So initialize to false.
Fixes: 1a15eb724aae ("btrfs: use btrfs_get_dev_args_from_path in dev removal ioctls")
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/btrfs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 190ad8af4f45a..26e82379747f8 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -3308,7 +3308,7 @@ static long btrfs_ioctl_rm_dev(struct file *file, void __user *arg)
struct block_device *bdev = NULL;
fmode_t mode;
int ret;
- bool cancel;
+ bool cancel = false;
if (!capable(CAP_SYS_ADMIN))
return -EPERM;
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] btrfs: initialize variable cancel
2022-01-21 13:45 [PATCH] btrfs: initialize variable cancel trix
@ 2022-01-21 15:40 ` Filipe Manana
2022-01-21 21:50 ` Anand Jain
2022-01-24 19:49 ` David Sterba
2 siblings, 0 replies; 4+ messages in thread
From: Filipe Manana @ 2022-01-21 15:40 UTC (permalink / raw)
To: trix
Cc: clm, josef, dsterba, nathan, ndesaulniers, anand.jain,
linux-btrfs, linux-kernel, llvm
On Fri, Jan 21, 2022 at 05:45:22AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Clang static analysis reports this problem
> ioctl.c:3333:8: warning: 3rd function call argument is an
> uninitialized value
> ret = exclop_start_or_cancel_reloc(fs_info,
>
> cancel is only set in one branch of an if-check and is
> always used. So initialize to false.
>
> Fixes: 1a15eb724aae ("btrfs: use btrfs_get_dev_args_from_path in dev removal ioctls")
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Could use a more precise subject like for example:
"btrfs: fix use of uninitialized variable at rm device ioctl"
Anyway, it looks good.
Thanks.
> ---
> fs/btrfs/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 190ad8af4f45a..26e82379747f8 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -3308,7 +3308,7 @@ static long btrfs_ioctl_rm_dev(struct file *file, void __user *arg)
> struct block_device *bdev = NULL;
> fmode_t mode;
> int ret;
> - bool cancel;
> + bool cancel = false;
>
> if (!capable(CAP_SYS_ADMIN))
> return -EPERM;
> --
> 2.26.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] btrfs: initialize variable cancel
2022-01-21 13:45 [PATCH] btrfs: initialize variable cancel trix
2022-01-21 15:40 ` Filipe Manana
@ 2022-01-21 21:50 ` Anand Jain
2022-01-24 19:49 ` David Sterba
2 siblings, 0 replies; 4+ messages in thread
From: Anand Jain @ 2022-01-21 21:50 UTC (permalink / raw)
To: trix, clm, josef, dsterba, nathan, ndesaulniers
Cc: linux-btrfs, linux-kernel, llvm
On 21/01/2022 21:45, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Clang static analysis reports this problem
> ioctl.c:3333:8: warning: 3rd function call argument is an
> uninitialized value
> ret = exclop_start_or_cancel_reloc(fs_info,
>
> cancel is only set in one branch of an if-check and is
> always used. So initialize to false.
>
> Fixes: 1a15eb724aae ("btrfs: use btrfs_get_dev_args_from_path in dev removal ioctls")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> fs/btrfs/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 190ad8af4f45a..26e82379747f8 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -3308,7 +3308,7 @@ static long btrfs_ioctl_rm_dev(struct file *file, void __user *arg)
> struct block_device *bdev = NULL;
> fmode_t mode;
> int ret;
> - bool cancel;
> + bool cancel = false;
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Thanks,
Anand
>
> if (!capable(CAP_SYS_ADMIN))
> return -EPERM;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] btrfs: initialize variable cancel
2022-01-21 13:45 [PATCH] btrfs: initialize variable cancel trix
2022-01-21 15:40 ` Filipe Manana
2022-01-21 21:50 ` Anand Jain
@ 2022-01-24 19:49 ` David Sterba
2 siblings, 0 replies; 4+ messages in thread
From: David Sterba @ 2022-01-24 19:49 UTC (permalink / raw)
To: trix
Cc: clm, josef, dsterba, nathan, ndesaulniers, anand.jain,
linux-btrfs, linux-kernel, llvm
On Fri, Jan 21, 2022 at 05:45:22AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Clang static analysis reports this problem
> ioctl.c:3333:8: warning: 3rd function call argument is an
> uninitialized value
> ret = exclop_start_or_cancel_reloc(fs_info,
>
> cancel is only set in one branch of an if-check and is
> always used. So initialize to false.
>
> Fixes: 1a15eb724aae ("btrfs: use btrfs_get_dev_args_from_path in dev removal ioctls")
> Signed-off-by: Tom Rix <trix@redhat.com>
Added to misc-next, with the updted subject line, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-24 19:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-21 13:45 [PATCH] btrfs: initialize variable cancel trix
2022-01-21 15:40 ` Filipe Manana
2022-01-21 21:50 ` Anand Jain
2022-01-24 19:49 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).