Re: [PATCH v12, 2/2] net: Add dm9051 driver

Re: [PATCH v12, 2/2] net: Add dm9051 driver

[kernel test robot]

Hi Joseph,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 9d922f5df53844228b9f7c62f2593f4f06c0b69b]

url:    https://github.com/0day-ci/linux/commits/Joseph-CHAMG/ADD-DM9051-ETHERNET-DRIVER/20220121-121713
base:   9d922f5df53844228b9f7c62f2593f4f06c0b69b
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220121/202201211736.UtU0eL2j-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d4baf3b1322b84816aa623d8e8cb45a49cb68b84)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/a6eb8dd02aed17af37a0b38fbcc250fd9ed9492d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Joseph-CHAMG/ADD-DM9051-ETHERNET-DRIVER/20220121-121713
        git checkout a6eb8dd02aed17af37a0b38fbcc250fd9ed9492d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/net/ethernet/davicom/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/davicom/dm9051.c:1076:26: warning: implicit conversion from 'unsigned long' to 'u32' (aka 'unsigned int') changes value from 18446744073709551613 to 4294967293 [-Wconstant-conversion]
           db->mdiobus->phy_mask = ~GENMASK(1, 1);
                                 ~ ^~~~~~~~~~~~~~
   1 warning generated.


vim +1076 drivers/net/ethernet/davicom/dm9051.c

  1062	
  1063	static int dm9051_mdiobus_register(struct board_info *db)
  1064	{
  1065		struct spi_device *spi = db->spidev;
  1066		int ret;
  1067	
  1068		db->mdiobus = devm_mdiobus_alloc(&spi->dev);
  1069		if (!db->mdiobus)
  1070			return -ENOMEM;
  1071	
  1072		db->mdiobus->priv = db;
  1073		db->mdiobus->read = dm9051_mdiobus_read;
  1074		db->mdiobus->write = dm9051_mdiobus_write;
  1075		db->mdiobus->name = "dm9051-mdiobus";
> 1076		db->mdiobus->phy_mask = ~GENMASK(1, 1);
  1077		db->mdiobus->parent = &spi->dev;
  1078		snprintf(db->mdiobus->id, MII_BUS_ID_SIZE,
  1079			 "dm9051-%s.%u", dev_name(&spi->dev), spi->chip_select);
  1080	
  1081		ret = devm_mdiobus_register(&spi->dev, db->mdiobus);
  1082		if (ret) {
  1083			dev_err(&spi->dev, "Could not register MDIO bus\n");
  1084			return ret;
  1085		}
  1086		return 0;
  1087	}
  1088	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org