* Re: [PATCH v5 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support
[not found] <20220126233454.3362047-4-eranian@google.com>
@ 2022-01-27 6:09 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-01-27 6:09 UTC (permalink / raw)
To: Stephane Eranian; +Cc: llvm, kbuild-all
Hi Stephane,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20220125]
[cannot apply to tip/x86/core rafael-pm/linux-next tip/perf/core v5.17-rc1 v5.16 v5.16-rc8 v5.17-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Stephane-Eranian/perf-core-add-perf_clear_branch_entry_bitfields-helper/20220127-083516
base: d25ee88530253138d0b20d43511ca5acbda4e9f7
config: i386-randconfig-a011-20220124 (https://download.01.org/0day-ci/archive/20220127/202201271410.cro07bYq-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f400a6012c668dfaa73462caf067ceb074e66c47)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/933d072f6e0c0409115a8038a89a56979a042d30
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stephane-Eranian/perf-core-add-perf_clear_branch_entry_bitfields-helper/20220127-083516
git checkout 933d072f6e0c0409115a8038a89a56979a042d30
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/events/amd/ drivers/acpi/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/events/amd/core.c:676:24: warning: variable 'hwc' set but not used [-Wunused-but-set-variable]
struct hw_perf_event *hwc;
^
1 warning generated.
vim +/hwc +676 arch/x86/events/amd/core.c
672
673 static void amd_pmu_enable_all(int added)
674 {
675 struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
> 676 struct hw_perf_event *hwc;
677 int idx;
678
679 amd_brs_enable_all();
680
681 for (idx = 0; idx < x86_pmu.num_counters; idx++) {
682 hwc = &cpuc->events[idx]->hw;
683
684 /* only activate events which are marked as active */
685 if (!test_bit(idx, cpuc->active_mask))
686 continue;
687
688 amd_pmu_enable_event(cpuc->events[idx]);
689 }
690 }
691
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v5 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support
[not found] <202201281639.FC1PUTSK-lkp@intel.com>
@ 2022-01-30 2:33 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-01-30 2:33 UTC (permalink / raw)
To: Stephane Eranian; +Cc: llvm, kbuild-all
Hi Stephane,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20220125]
[cannot apply to tip/x86/core rafael-pm/linux-next tip/perf/core v5.17-rc1 v5.16 v5.16-rc8 v5.17-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Stephane-Eranian/perf-core-add-perf_clear_branch_entry_bitfields-helper/20220127-083516
base: d25ee88530253138d0b20d43511ca5acbda4e9f7
config: x86_64-randconfig-c007-20220124 (https://download.01.org/0day-ci/archive/20220128/202201281639.FC1PUTSK-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45ee44b1f32ffdbc995e6fec806271b4b3ba4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/933d072f6e0c0409115a8038a89a56979a042d30
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stephane-Eranian/perf-core-add-perf_clear_branch_entry_bitfields-helper/20220127-083516
git checkout 933d072f6e0c0409115a8038a89a56979a042d30
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <yujie.liu@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
>> arch/x86/events/amd/core.c:682:3: warning: Value stored to 'hwc' is never read [clang-analyzer-deadcode.DeadStores]
hwc = &cpuc->events[idx]->hw;
^ ~~~~~~~~~~~~~~~~~~~~~~
vim +/hwc +682 arch/x86/events/amd/core.c
933d072f6e0c04 Stephane Eranian 2022-01-26 672
933d072f6e0c04 Stephane Eranian 2022-01-26 673 static void amd_pmu_enable_all(int added)
933d072f6e0c04 Stephane Eranian 2022-01-26 674 {
933d072f6e0c04 Stephane Eranian 2022-01-26 675 struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
933d072f6e0c04 Stephane Eranian 2022-01-26 @676 struct hw_perf_event *hwc;
933d072f6e0c04 Stephane Eranian 2022-01-26 677 int idx;
933d072f6e0c04 Stephane Eranian 2022-01-26 678
933d072f6e0c04 Stephane Eranian 2022-01-26 679 amd_brs_enable_all();
933d072f6e0c04 Stephane Eranian 2022-01-26 680
933d072f6e0c04 Stephane Eranian 2022-01-26 681 for (idx = 0; idx < x86_pmu.num_counters; idx++) {
933d072f6e0c04 Stephane Eranian 2022-01-26 @682 hwc = &cpuc->events[idx]->hw;
933d072f6e0c04 Stephane Eranian 2022-01-26 683
933d072f6e0c04 Stephane Eranian 2022-01-26 684 /* only activate events which are marked as active */
933d072f6e0c04 Stephane Eranian 2022-01-26 685 if (!test_bit(idx, cpuc->active_mask))
933d072f6e0c04 Stephane Eranian 2022-01-26 686 continue;
933d072f6e0c04 Stephane Eranian 2022-01-26 687
933d072f6e0c04 Stephane Eranian 2022-01-26 688 amd_pmu_enable_event(cpuc->events[idx]);
933d072f6e0c04 Stephane Eranian 2022-01-26 689 }
933d072f6e0c04 Stephane Eranian 2022-01-26 690 }
933d072f6e0c04 Stephane Eranian 2022-01-26 691
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-30 2:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220126233454.3362047-4-eranian@google.com>
2022-01-27 6:09 ` [PATCH v5 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support kernel test robot
[not found] <202201281639.FC1PUTSK-lkp@intel.com>
2022-01-30 2:33 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).