Re: [PATCH] mm: move page-writeback sysctls to is own file

Re: [PATCH] mm: move page-writeback sysctls to is own file

[kernel test robot]

Hi zhanglianjie,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.17-rc1 next-20220128]
[cannot apply to hnaz-mm/master linux/master kees/for-next/pstore]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/zhanglianjie/mm-move-page-writeback-sysctls-to-is-own-file/20220128-172052
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 23a46422c56144939c091c76cf389aa863ce9c18
config: arm64-buildonly-randconfig-r005-20220127 (https://download.01.org/0day-ci/archive/20220129/202201290141.GDKdUC72-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45ee44b1f32ffdbc995e6fec806271b4b3ba4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/d24502aa729978894feb2de10481cd139ae5bb42
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review zhanglianjie/mm-move-page-writeback-sysctls-to-is-own-file/20220128-172052
        git checkout d24502aa729978894feb2de10481cd139ae5bb42
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   mm/page-writeback.c:509:5: warning: no previous prototype for function 'dirty_background_ratio_handler' [-Wmissing-prototypes]
   int dirty_background_ratio_handler(struct ctl_table *table, int write,
       ^
   mm/page-writeback.c:509:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int dirty_background_ratio_handler(struct ctl_table *table, int write,
   ^
   static 
   mm/page-writeback.c:520:5: warning: no previous prototype for function 'dirty_background_bytes_handler' [-Wmissing-prototypes]
   int dirty_background_bytes_handler(struct ctl_table *table, int write,
       ^
   mm/page-writeback.c:520:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int dirty_background_bytes_handler(struct ctl_table *table, int write,
   ^
   static 
   mm/page-writeback.c:531:5: warning: no previous prototype for function 'dirty_ratio_handler' [-Wmissing-prototypes]
   int dirty_ratio_handler(struct ctl_table *table, int write, void *buffer,
       ^
   mm/page-writeback.c:531:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int dirty_ratio_handler(struct ctl_table *table, int write, void *buffer,
   ^
   static 
   mm/page-writeback.c:545:5: warning: no previous prototype for function 'dirty_bytes_handler' [-Wmissing-prototypes]
   int dirty_bytes_handler(struct ctl_table *table, int write,
       ^
   mm/page-writeback.c:545:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int dirty_bytes_handler(struct ctl_table *table, int write,
   ^
   static 
   mm/page-writeback.c:2002:5: warning: no previous prototype for function 'dirty_writeback_centisecs_handler' [-Wmissing-prototypes]
   int dirty_writeback_centisecs_handler(struct ctl_table *table, int write,
       ^
   mm/page-writeback.c:2002:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int dirty_writeback_centisecs_handler(struct ctl_table *table, int write,
   ^
   static 
>> mm/page-writeback.c:93:28: warning: unused variable 'dirty_bytes_min' [-Wunused-const-variable]
   static const unsigned long dirty_bytes_min = 2 * PAGE_SIZE;
                              ^
   6 warnings generated.


vim +/dirty_bytes_min +93 mm/page-writeback.c

    91	
    92	/* this is needed for the proc_doulongvec_minmax of vm_dirty_bytes */
  > 93	static const unsigned long dirty_bytes_min = 2 * PAGE_SIZE;
    94	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org