Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

[kernel test robot]

Hi Marek,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on drm/drm-next]
[also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc2 next-20220204]
[cannot apply to airlied/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220207-025808
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20220207/202202070546.PJcFF726-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6daaf5a44925592c764c59219b0024ee06317028)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/75b77e11a90d2a041b405a10dce7e1be6aab61a0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220207-025808
        git checkout 75b77e11a90d2a041b405a10dce7e1be6aab61a0
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/mxsfb/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/mxsfb/mxsfb_drv.c:324:33: error: too many arguments to function call, expected single argument 'addr', have 2 arguments
           u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
                       ~~~~~              ^~~~~~~~~~~~~~~~
   drivers/gpu/drm/mxsfb/mxsfb_regs.h:29:27: note: expanded from macro 'LCDC_V4_CRC_STAT'
   #define LCDC_V4_CRC_STAT                0x1a0
                                           ^~~~~
   arch/x86/include/asm/io.h:60:17: note: 'readl' declared here
   build_mmio_read(readl, "l", unsigned int, "=r", :"memory")
                   ^
   1 error generated.


vim +/addr +324 drivers/gpu/drm/mxsfb/mxsfb_drv.c

   317	
   318	static ssize_t mxsfb_frame_checksum_show(struct device *dev,
   319						     struct device_attribute *attr,
   320						     char *buf)
   321	{
   322		struct drm_device *drm = dev_get_drvdata(dev);
   323		struct mxsfb_drm_private *mxsfb = drm->dev_private;
 > 324		u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
   325		u32 swcrc = 0xffffffff;
   326		int i;
   327	
   328		if (mxsfb->gem_vaddr) {
   329			for (i = 0; i < mxsfb->gem_size / 4; i++) {
   330				u32 data = bitrev32(((u32 *)mxsfb->gem_vaddr)[i]);
   331				swcrc = crc32(swcrc, &data, 4);
   332			}
   333			swcrc = bitrev32(swcrc);
   334		}
   335	
   336		return sysfs_emit(buf, "HW:%08x,SW:%08x,OK:%d\n", hwcrc, swcrc, hwcrc == swcrc);
   337	}
   338	static DEVICE_ATTR(frame_checksum, 0444, mxsfb_frame_checksum_show, NULL);
   339	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

[kernel test robot]

Hi Marek,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on drm/drm-next]
[also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc2 next-20220204]
[cannot apply to airlied/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220207-025808
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: riscv-randconfig-r031-20220207 (https://download.01.org/0day-ci/archive/20220207/202202070617.cZxa0dIi-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6daaf5a44925592c764c59219b0024ee06317028)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/75b77e11a90d2a041b405a10dce7e1be6aab61a0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220207-025808
        git checkout 75b77e11a90d2a041b405a10dce7e1be6aab61a0
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/gpu/drm/mxsfb/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> drivers/gpu/drm/mxsfb/mxsfb_drv.c:324:33: error: too many arguments provided to function-like macro invocation
           u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
                                          ^
   arch/riscv/include/asm/mmio.h:140:9: note: macro 'readl' defined here
   #define readl(c)        ({ u32 __v; __io_br(); __v = readl_cpu(c); __io_ar(__v); __v; })
           ^
>> drivers/gpu/drm/mxsfb/mxsfb_drv.c:324:14: error: use of undeclared identifier 'readl'; did you mean 'vread'?
           u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
                       ^~~~~
                       vread
   include/linux/vmalloc.h:251:13: note: 'vread' declared here
   extern long vread(char *buf, char *addr, unsigned long count);
               ^
>> drivers/gpu/drm/mxsfb/mxsfb_drv.c:324:6: warning: incompatible pointer to integer conversion initializing 'u32' (aka 'unsigned int') with an expression of type 'long (char *, char *, unsigned long)' [-Wint-conversion]
           u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
               ^       ~~~~~
   1 warning and 2 errors generated.


vim +324 drivers/gpu/drm/mxsfb/mxsfb_drv.c

   317	
   318	static ssize_t mxsfb_frame_checksum_show(struct device *dev,
   319						     struct device_attribute *attr,
   320						     char *buf)
   321	{
   322		struct drm_device *drm = dev_get_drvdata(dev);
   323		struct mxsfb_drm_private *mxsfb = drm->dev_private;
 > 324		u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
   325		u32 swcrc = 0xffffffff;
   326		int i;
   327	
   328		if (mxsfb->gem_vaddr) {
   329			for (i = 0; i < mxsfb->gem_size / 4; i++) {
   330				u32 data = bitrev32(((u32 *)mxsfb->gem_vaddr)[i]);
   331				swcrc = crc32(swcrc, &data, 4);
   332			}
   333			swcrc = bitrev32(swcrc);
   334		}
   335	
   336		return sysfs_emit(buf, "HW:%08x,SW:%08x,OK:%d\n", hwcrc, swcrc, hwcrc == swcrc);
   337	}
   338	static DEVICE_ATTR(frame_checksum, 0444, mxsfb_frame_checksum_show, NULL);
   339	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org