* Re: [PATCH 5/6] ath11k: Register DBR event handler for CFR data
[not found] <1644592075-27082-6-git-send-email-quic_vnaralas@quicinc.com>
@ 2022-02-12 18:17 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-02-12 18:17 UTC (permalink / raw)
To: Venkateswara Naralasetty, ath11k
Cc: llvm, kbuild-all, linux-wireless, Venkateswara Naralasetty
Hi Venkateswara,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kvalo-ath/ath-next]
[cannot apply to wireless-next/main wireless/main jberg-mac80211-next/master jberg-mac80211/master v5.17-rc3 next-20220211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Venkateswara-Naralasetty/ath11k-add-single-shot-periodic-CFR-capture-support-for-IPQ8074/20220211-230911
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220213/202202130103.qvrDOuTL-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project f6685f774697c85d6a352dcea013f46a99f9fe31)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/14cd77b4e3109da2eb6b33501640153852c5d2a7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Venkateswara-Naralasetty/ath11k-add-single-shot-periodic-CFR-capture-support-for-IPQ8074/20220211-230911
git checkout 14cd77b4e3109da2eb6b33501640153852c5d2a7
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/wireless/ath/ath11k/ drivers/platform/x86/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/ath/ath11k/cfr.c:40:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
case ATH11K_CFR_PREAMBLE_TYPE_HT:
^
drivers/net/wireless/ath/ath11k/cfr.c:40:2: note: insert '__attribute__((fallthrough));' to silence this warning
case ATH11K_CFR_PREAMBLE_TYPE_HT:
^
__attribute__((fallthrough));
drivers/net/wireless/ath/ath11k/cfr.c:40:2: note: insert 'break;' to avoid fall-through
case ATH11K_CFR_PREAMBLE_TYPE_HT:
^
break;
drivers/net/wireless/ath/ath11k/cfr.c:515:6: warning: no previous prototype for function 'ath11k_cfr_ring_free' [-Wmissing-prototypes]
void ath11k_cfr_ring_free(struct ath11k *ar)
^
drivers/net/wireless/ath/ath11k/cfr.c:515:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void ath11k_cfr_ring_free(struct ath11k *ar)
^
static
2 warnings generated.
vim +40 drivers/net/wireless/ath/ath11k/cfr.c
18
19 static int cfr_calculate_tones_from_dma_hdr(struct ath11k_cfir_dma_hdr *hdr)
20 {
21 u8 bw = FIELD_GET(CFIR_DMA_HDR_INFO1_UPLOAD_PKT_BW, hdr->info1);
22 u8 preamble = FIELD_GET(CFIR_DMA_HDR_INFO1_PREAMBLE_TYPE, hdr->info1);
23
24 switch (preamble) {
25 case ATH11K_CFR_PREAMBLE_TYPE_LEGACY:
26 case ATH11K_CFR_PREAMBLE_TYPE_VHT:
27 switch (bw) {
28 case 0:
29 return TONES_IN_20MHZ;
30 case 1: /* DUP40/VHT40 */
31 return TONES_IN_40MHZ;
32 case 2: /* DUP80/VHT80 */
33 return TONES_IN_80MHZ;
34 case 3: /* DUP160/VHT160 */
35 return TONES_IN_160MHZ;
36 default:
37 break;
38 }
39
> 40 case ATH11K_CFR_PREAMBLE_TYPE_HT:
41 switch (bw) {
42 case 0:
43 return TONES_IN_20MHZ;
44 case 1:
45 return TONES_IN_40MHZ;
46 }
47 }
48
49 return TONES_INVALID;
50 }
51
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] only message in thread