* Re: [PATCH 1/2] asus-wmi: Use led multicolor class for keyboard backlight [not found] <20220211200122.9821-2-abhijeetviswa@gmail.com> @ 2022-02-12 19:08 ` kernel test robot 2022-02-13 6:20 ` Abhijeet Viswa 0 siblings, 1 reply; 2+ messages in thread From: kernel test robot @ 2022-02-12 19:08 UTC (permalink / raw) To: Abhijeet V, Corentin Chary, Hans de Goede, Mark Gross Cc: llvm, kbuild-all, acpi4asus-user, platform-driver-x86, linux-kernel, Abhijeet V Hi Abhijeet, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.17-rc3 next-20220211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Abhijeet-V/asus-wmi-Keyboard-rgb-led-multicolor-support/20220212-040427 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f1baf68e1383f6ed93eb9cff2866d46562607a43 config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220213/202202130255.uwrbJQfB-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project f6685f774697c85d6a352dcea013f46a99f9fe31) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/860e9e7427b00b9dbd0c35851cecda00be1968f2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Abhijeet-V/asus-wmi-Keyboard-rgb-led-multicolor-support/20220212-040427 git checkout 860e9e7427b00b9dbd0c35851cecda00be1968f2 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/x86/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> drivers/platform/x86/asus-wmi.c:958:5: warning: no previous prototype for function 'kbd_led_classdev_init' [-Wmissing-prototypes] int kbd_led_classdev_init(struct asus_wmi *asus, int brightness) ^ drivers/platform/x86/asus-wmi.c:958:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int kbd_led_classdev_init(struct asus_wmi *asus, int brightness) ^ static 1 warning generated. vim +/kbd_led_classdev_init +958 drivers/platform/x86/asus-wmi.c 957 > 958 int kbd_led_classdev_init(struct asus_wmi *asus, int brightness) 959 { 960 int rv; 961 962 asus->kbd_led_wk = brightness; 963 asus->kbd_led_mc.led_cdev.name = "asus::kbd_backlight"; 964 asus->kbd_led_mc.led_cdev.flags = LED_BRIGHT_HW_CHANGED; 965 asus->kbd_led_mc.led_cdev.brightness_set = kbd_led_brightness_set; 966 asus->kbd_led_mc.led_cdev.brightness_get = kbd_led_brightness_get; 967 asus->kbd_led_mc.led_cdev.max_brightness = 3; 968 969 asus->kbd_led_mc.num_colors = ASUS_KBD_SUBLED_COUNT; 970 971 rv = led_classdev_multicolor_register(&asus->platform_device->dev, 972 &asus->kbd_led_mc); 973 return rv; 974 } 975 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] asus-wmi: Use led multicolor class for keyboard backlight 2022-02-12 19:08 ` [PATCH 1/2] asus-wmi: Use led multicolor class for keyboard backlight kernel test robot @ 2022-02-13 6:20 ` Abhijeet Viswa 0 siblings, 0 replies; 2+ messages in thread From: Abhijeet Viswa @ 2022-02-13 6:20 UTC (permalink / raw) To: kernel test robot Cc: llvm, kbuild-all, acpi4asus-user, platform-driver-x86, linux-kernel, Hans de Goede, Corentin Chary, Mark Gross, Luke D. Jones Hi, Not sure if this email is monitored. But since you asked me to, here ya go. On 13/02/22 00:38, kernel test robot wrote: > Hi Abhijeet, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v5.17-rc3 next-20220211] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > Base is intended to be the linux-next/master tree (commit 6d9bd4ad4ca08b1114e814c2c42383b8b13be631). > url: https://github.com/0day-ci/linux/commits/Abhijeet-V/asus-wmi-Keyboard-rgb-led-multicolor-support/20220212-040427 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f1baf68e1383f6ed93eb9cff2866d46562607a43 > config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220213/202202130255.uwrbJQfB-lkp@intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project f6685f774697c85d6a352dcea013f46a99f9fe31) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/860e9e7427b00b9dbd0c35851cecda00be1968f2 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Abhijeet-V/asus-wmi-Keyboard-rgb-led-multicolor-support/20220212-040427 > git checkout 860e9e7427b00b9dbd0c35851cecda00be1968f2 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/x86/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > >>> drivers/platform/x86/asus-wmi.c:958:5: warning: no previous prototype for function 'kbd_led_classdev_init' [-Wmissing-prototypes] > int kbd_led_classdev_init(struct asus_wmi *asus, int brightness) > ^ > drivers/platform/x86/asus-wmi.c:958:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > int kbd_led_classdev_init(struct asus_wmi *asus, int brightness) > ^ > static > 1 warning generated. > > > vim +/kbd_led_classdev_init +958 drivers/platform/x86/asus-wmi.c > > 957 > > 958 int kbd_led_classdev_init(struct asus_wmi *asus, int brightness) > 959 { > 960 int rv; > 961 > 962 asus->kbd_led_wk = brightness; > 963 asus->kbd_led_mc.led_cdev.name = "asus::kbd_backlight"; > 964 asus->kbd_led_mc.led_cdev.flags = LED_BRIGHT_HW_CHANGED; > 965 asus->kbd_led_mc.led_cdev.brightness_set = kbd_led_brightness_set; > 966 asus->kbd_led_mc.led_cdev.brightness_get = kbd_led_brightness_get; > 967 asus->kbd_led_mc.led_cdev.max_brightness = 3; > 968 > 969 asus->kbd_led_mc.num_colors = ASUS_KBD_SUBLED_COUNT; > 970 > 971 rv = led_classdev_multicolor_register(&asus->platform_device->dev, > 972 &asus->kbd_led_mc); > 973 return rv; > 974 } > 975 Bot or not, thanks for the report. I'll fix these in a v2 after others get a chance to review v1. Thanks, Abhijeet > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-13 6:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220211200122.9821-2-abhijeetviswa@gmail.com>
2022-02-12 19:08 ` [PATCH 1/2] asus-wmi: Use led multicolor class for keyboard backlight kernel test robot
2022-02-13 6:20 ` Abhijeet Viswa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox