Re: [PATCH v2 08/12] pinctrl: renesas: r8a779f0: Add MMC pins, groups, and function

[kernel test robot <lkp@intel.com>]

Hi Geert,

I love your patch! Yet something to improve:

[auto build test ERROR on geert-renesas-drivers/renesas-pinctrl]
[also build test ERROR on robh/for-next linusw-pinctrl/devel v5.17-rc5 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855
base:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-pinctrl
config: arm64-randconfig-r021-20220221 (https://download.01.org/0day-ci/archive/20220222/202202220816.4R3DRnX0-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/06b5c197da936f9f7d6dc715ff6ae7ab6aee760d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855
        git checkout 06b5c197da936f9f7d6dc715ff6ae7ab6aee760d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/pinctrl/renesas/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/pinctrl/renesas/pfc-r8a779f0.c:851:2: error: implicit declaration of function 'BUS_DATA_PIN_GROUP' [-Werror,-Wimplicit-function-declaration]
           BUS_DATA_PIN_GROUP(mmc_data, 1),
           ^
>> drivers/pinctrl/renesas/pfc-r8a779f0.c:851:21: error: use of undeclared identifier 'mmc_data'
           BUS_DATA_PIN_GROUP(mmc_data, 1),
                              ^
   drivers/pinctrl/renesas/pfc-r8a779f0.c:852:21: error: use of undeclared identifier 'mmc_data'
           BUS_DATA_PIN_GROUP(mmc_data, 4),
                              ^
   drivers/pinctrl/renesas/pfc-r8a779f0.c:853:21: error: use of undeclared identifier 'mmc_data'
           BUS_DATA_PIN_GROUP(mmc_data, 8),
                              ^
   drivers/pinctrl/renesas/pfc-r8a779f0.c:1489:20: error: incompatible function pointer types initializing 'int (*)(struct sh_pfc *, unsigned int, u32 *)' (aka 'int (*)(struct sh_pfc *, unsigned int, unsigned int *)') with an expression of type 'int (unsigned int, u32 *)' (aka 'int (unsigned int, unsigned int *)') [-Werror,-Wincompatible-function-pointer-types]
           .pin_to_pocctrl = r8a779f0_pin_to_pocctrl,
                             ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pinctrl/renesas/pfc-r8a779f0.c:1504:15: error: invalid application of 'sizeof' to an incomplete type 'const struct sh_pfc_pin_group[]'
           .nr_groups = ARRAY_SIZE(pinmux_groups),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/kernel.h:55:32: note: expanded from macro 'ARRAY_SIZE'
   #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                  ^~~~~
   6 errors generated.


vim +/BUS_DATA_PIN_GROUP +851 drivers/pinctrl/renesas/pfc-r8a779f0.c

   825	
   826	static const struct sh_pfc_pin_group pinmux_groups[] = {
   827		SH_PFC_PIN_GROUP(hscif0_data),
   828		SH_PFC_PIN_GROUP(hscif0_clk),
   829		SH_PFC_PIN_GROUP(hscif0_ctrl),
   830		SH_PFC_PIN_GROUP(hscif1_data),
   831		SH_PFC_PIN_GROUP(hscif1_clk),
   832		SH_PFC_PIN_GROUP(hscif1_ctrl),
   833		SH_PFC_PIN_GROUP(hscif2_data),
   834		SH_PFC_PIN_GROUP(hscif2_clk),
   835		SH_PFC_PIN_GROUP(hscif2_ctrl),
   836		SH_PFC_PIN_GROUP(hscif3_data),
   837		SH_PFC_PIN_GROUP(hscif3_clk),
   838		SH_PFC_PIN_GROUP(hscif3_ctrl),
   839		SH_PFC_PIN_GROUP(i2c0),
   840		SH_PFC_PIN_GROUP(i2c1),
   841		SH_PFC_PIN_GROUP(i2c2),
   842		SH_PFC_PIN_GROUP(i2c3),
   843		SH_PFC_PIN_GROUP(i2c4),
   844		SH_PFC_PIN_GROUP(i2c5),
   845		SH_PFC_PIN_GROUP(intc_ex_irq0),
   846		SH_PFC_PIN_GROUP(intc_ex_irq1),
   847		SH_PFC_PIN_GROUP(intc_ex_irq2),
   848		SH_PFC_PIN_GROUP(intc_ex_irq3),
   849		SH_PFC_PIN_GROUP(intc_ex_irq4),
   850		SH_PFC_PIN_GROUP(intc_ex_irq5),
 > 851		BUS_DATA_PIN_GROUP(mmc_data, 1),
   852		BUS_DATA_PIN_GROUP(mmc_data, 4),
   853		BUS_DATA_PIN_GROUP(mmc_data, 8),
   854		SH_PFC_PIN_GROUP(mmc_ctrl),
   855		SH_PFC_PIN_GROUP(mmc_cd),
   856		SH_PFC_PIN_GROUP(mmc_wp),
   857		SH_PFC_PIN_GROUP(mmc_ds),
   858		SH_PFC_PIN_GROUP(scif0_data),
   859		SH_PFC_PIN_GROUP(scif0_clk),
   860		SH_PFC_PIN_GROUP(scif0_ctrl),
   861		SH_PFC_PIN_GROUP(scif1_data),
   862		SH_PFC_PIN_GROUP(scif1_clk),
   863		SH_PFC_PIN_GROUP(scif1_ctrl),
   864		SH_PFC_PIN_GROUP(scif3_data),
   865		SH_PFC_PIN_GROUP(scif3_clk),
   866		SH_PFC_PIN_GROUP(scif3_ctrl),
   867		SH_PFC_PIN_GROUP(scif4_data),
   868		SH_PFC_PIN_GROUP(scif4_clk),
   869		SH_PFC_PIN_GROUP(scif4_ctrl),
   870		SH_PFC_PIN_GROUP(scif_clk),
   871	};
   872	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org