* [PATCH] iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler()
@ 2022-02-24 21:10 Nathan Chancellor
2022-02-26 18:00 ` Jonathan Cameron
2022-02-26 19:49 ` Andy Shevchenko
0 siblings, 2 replies; 4+ messages in thread
From: Nathan Chancellor @ 2022-02-24 21:10 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Cosmin Tanislav,
Jonathan Cameron
Cc: linux-iio, patches, llvm, Nathan Chancellor, kernel test robot
Clang warns:
drivers/iio/accel/adxl367.c:887:2: error: variable 'handled' is uninitialized when used here [-Werror,-Wuninitialized]
handled |= adxl367_push_event(indio_dev, status);
^~~~~~~
drivers/iio/accel/adxl367.c:879:14: note: initialize the variable 'handled' to silence this warning
bool handled;
^
= 0
1 error generated.
This should have used '=' instead of '|='; make that change to resolve
the warning.
Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1605
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/iio/accel/adxl367.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
index b452d74b1d4d..350a89b61179 100644
--- a/drivers/iio/accel/adxl367.c
+++ b/drivers/iio/accel/adxl367.c
@@ -884,7 +884,7 @@ static irqreturn_t adxl367_irq_handler(int irq, void *private)
if (ret)
return IRQ_NONE;
- handled |= adxl367_push_event(indio_dev, status);
+ handled = adxl367_push_event(indio_dev, status);
handled |= adxl367_push_fifo_data(indio_dev, status, fifo_entries);
return handled ? IRQ_HANDLED : IRQ_NONE;
base-commit: 2be8795a609800e5071d868d459ce29232fce2c8
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler()
2022-02-24 21:10 [PATCH] iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler() Nathan Chancellor
@ 2022-02-26 18:00 ` Jonathan Cameron
2022-02-26 19:49 ` Andy Shevchenko
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2022-02-26 18:00 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Lars-Peter Clausen, Michael Hennerich, Cosmin Tanislav, linux-iio,
patches, llvm, kernel test robot, Colin Ian King
On Thu, 24 Feb 2022 14:10:34 -0700
Nathan Chancellor <nathan@kernel.org> wrote:
> Clang warns:
>
> drivers/iio/accel/adxl367.c:887:2: error: variable 'handled' is uninitialized when used here [-Werror,-Wuninitialized]
> handled |= adxl367_push_event(indio_dev, status);
> ^~~~~~~
> drivers/iio/accel/adxl367.c:879:14: note: initialize the variable 'handled' to silence this warning
> bool handled;
> ^
> = 0
> 1 error generated.
>
> This should have used '=' instead of '|='; make that change to resolve
> the warning.
>
> Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1605
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Applied to the togreg branch of iio.git.
I also added a second reported-by to reflect the next patch setting in my inbox which
was Colin fixing the same thing.
Thanks!
> ---
> drivers/iio/accel/adxl367.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
> index b452d74b1d4d..350a89b61179 100644
> --- a/drivers/iio/accel/adxl367.c
> +++ b/drivers/iio/accel/adxl367.c
> @@ -884,7 +884,7 @@ static irqreturn_t adxl367_irq_handler(int irq, void *private)
> if (ret)
> return IRQ_NONE;
>
> - handled |= adxl367_push_event(indio_dev, status);
> + handled = adxl367_push_event(indio_dev, status);
> handled |= adxl367_push_fifo_data(indio_dev, status, fifo_entries);
>
> return handled ? IRQ_HANDLED : IRQ_NONE;
>
> base-commit: 2be8795a609800e5071d868d459ce29232fce2c8
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler()
2022-02-24 21:10 [PATCH] iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler() Nathan Chancellor
2022-02-26 18:00 ` Jonathan Cameron
@ 2022-02-26 19:49 ` Andy Shevchenko
2022-02-27 12:02 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2022-02-26 19:49 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Lars-Peter Clausen, Michael Hennerich, Cosmin Tanislav,
Jonathan Cameron, linux-iio, patches, llvm, kernel test robot
On Thu, Feb 24, 2022 at 11:25 PM Nathan Chancellor <nathan@kernel.org> wrote:
...
> drivers/iio/accel/adxl367.c:879:14: note: initialize the variable 'handled' to silence this warning
> bool handled;
> ^
> = 0
Bad advice (at minimum it should be false, but in general it might
hide a real issue)
> 1 error generated.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler()
2022-02-26 19:49 ` Andy Shevchenko
@ 2022-02-27 12:02 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2022-02-27 12:02 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Nathan Chancellor, Lars-Peter Clausen, Michael Hennerich,
Cosmin Tanislav, linux-iio, patches, llvm, kernel test robot
On Sat, 26 Feb 2022 21:49:16 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Thu, Feb 24, 2022 at 11:25 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> ...
>
> > drivers/iio/accel/adxl367.c:879:14: note: initialize the variable 'handled' to silence this warning
> > bool handled;
> > ^
>
> > = 0
>
> Bad advice (at minimum it should be false, but in general it might
> hide a real issue)
True. Thankfully Nathan did the right thing and looked for the real
problem :)
Jonathan
>
> > 1 error generated.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-27 11:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-24 21:10 [PATCH] iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler() Nathan Chancellor
2022-02-26 18:00 ` Jonathan Cameron
2022-02-26 19:49 ` Andy Shevchenko
2022-02-27 12:02 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox