From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Cosmin Tanislav <cosmin.tanislav@analog.com>,
linux-iio <linux-iio@vger.kernel.org>,
patches@lists.linux.dev, llvm@lists.linux.dev,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler()
Date: Sun, 27 Feb 2022 12:02:15 +0000 [thread overview]
Message-ID: <20220227120215.4c112bc2@jic23-huawei> (raw)
In-Reply-To: <CAHp75VdW8g_bvPvvfWOW5SUkEm9PYu8UvO9Mf_wshLLB3u=zPw@mail.gmail.com>
On Sat, 26 Feb 2022 21:49:16 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Thu, Feb 24, 2022 at 11:25 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> ...
>
> > drivers/iio/accel/adxl367.c:879:14: note: initialize the variable 'handled' to silence this warning
> > bool handled;
> > ^
>
> > = 0
>
> Bad advice (at minimum it should be false, but in general it might
> hide a real issue)
True. Thankfully Nathan did the right thing and looked for the real
problem :)
Jonathan
>
> > 1 error generated.
>
prev parent reply other threads:[~2022-02-27 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 21:10 [PATCH] iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler() Nathan Chancellor
2022-02-26 18:00 ` Jonathan Cameron
2022-02-26 19:49 ` Andy Shevchenko
2022-02-27 12:02 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220227120215.4c112bc2@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=cosmin.tanislav@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox