From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D67E84A91 for ; Sun, 27 Feb 2022 16:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645980244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V5Y+mhXtEe4aHWk4DE77nNDoAlUo3znM4yBU3KLbx5o=; b=OUalcefBWArWR6GhnfmbGtrEZ/bPX4DU/czZoijzTwPfWXnlHsOQnQc9q4kARkukw6UI5W KXhmD1+VReP+iQqI7XjwaVDj/LOSH7+BcNehAn4lJN8dc0qSvEl1s5ocBLJcZ7SNmY/Is+ M/PGf+2CdiO6b/0/2LEXG+Q5ExVLPyM= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-251-4zOr6PAUMyq6yldQSrSVzw-1; Sun, 27 Feb 2022 11:44:03 -0500 X-MC-Unique: 4zOr6PAUMyq6yldQSrSVzw-1 Received: by mail-qk1-f199.google.com with SMTP id t10-20020a37aa0a000000b00605b9764f71so9444034qke.22 for ; Sun, 27 Feb 2022 08:44:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=V5Y+mhXtEe4aHWk4DE77nNDoAlUo3znM4yBU3KLbx5o=; b=y+Svwo1miHvbKzxYT84eHgbk4E5DwGw57roX3fKVuu3EIHu0WuCeEEcVUrUEdTMpZo n8oJxMmpltQHkgmx6UKhmfYCQcPnQEluR12uJJWU6G4z4xvRBmORrGOD9HgAi41G9kYU Hyv1RCVD1YjnD7+T27jv7eIX+d8SsAWLy+3tSijK3oABIbCr4PEH5bHtdLhPK6dzY7E7 FbvOLfZ/VwxFmrAVxhjlwKKOdk8bh0EiaXvkChVi4lSBq5B+EbkbaTslgPny2zP8Hf7Q 0rfUtRatBvmGRzHxnEezzon1zZonGfewo4uWZ7kZX92DEGdZLHPYPKgl32A/K39lqO+y 5n/g== X-Gm-Message-State: AOAM533o7hsp2Wa+PZoOZDxA6HSlDsQ7HX8PBCVobjtYZ1GtN6vcDzXh s47yimYGAbJqnAXoRXNiaRMQte7q0rA1nTkmeIyvuf379nOX2Cpa6A6Y4UMLu0FyV5J6m8OGdh9 lGgMYsMi3H1fwTg== X-Received: by 2002:a05:620a:1fc:b0:60d:d438:d628 with SMTP id x28-20020a05620a01fc00b0060dd438d628mr9489736qkn.388.1645980242782; Sun, 27 Feb 2022 08:44:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmEEmzM5eDcwZIwdUdPIYKMl5r3tEeMsKZSwUZGmeUMBHmHQtSkJ2w3iQrxB7UtVNBvR5apQ== X-Received: by 2002:a05:620a:1fc:b0:60d:d438:d628 with SMTP id x28-20020a05620a01fc00b0060dd438d628mr9489721qkn.388.1645980242555; Sun, 27 Feb 2022 08:44:02 -0800 (PST) Received: from localhost.localdomain.com (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id w140-20020a376292000000b00648e88c1f05sm4010675qkb.67.2022.02.27.08.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 08:44:02 -0800 (PST) From: trix@redhat.com To: jic23@kernel.org, lars@metafoo.de, matthias.bgg@gmail.com, nathan@kernel.org, ndesaulniers@google.com, linus.walleij@linaro.org, ardeleanalex@gmail.com Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] iio: adc: mt6360: strengthen return check of mt6360_adc_read_channel Date: Sun, 27 Feb 2022 08:43:57 -0800 Message-Id: <20220227164357.84742-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" From: Tom Rix Clang static analysis reports this issue mt6360-adc.c:277:20: warning: Assigned value is garbage or undefined data.values[i++] = val; ^ ~~~ val is set by a successful call to m6360_adc_read_channel(). A negative return is checked but within m6360_adc_read_channel, a non zero check is done. Strengthen the check to non zero. Signed-off-by: Tom Rix --- drivers/iio/adc/mt6360-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/mt6360-adc.c b/drivers/iio/adc/mt6360-adc.c index 07c0e67683910..9fb6dc305a392 100644 --- a/drivers/iio/adc/mt6360-adc.c +++ b/drivers/iio/adc/mt6360-adc.c @@ -269,7 +269,7 @@ static irqreturn_t mt6360_adc_trigger_handler(int irq, void *p) memset(&data, 0, sizeof(data)); for_each_set_bit(bit, indio_dev->active_scan_mask, indio_dev->masklength) { ret = mt6360_adc_read_channel(mad, bit, &val); - if (ret < 0) { + if (ret) { dev_warn(&indio_dev->dev, "Failed to get channel %d conversion val\n", bit); goto out; } -- 2.26.3