From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 741F92F21 for ; Thu, 3 Mar 2022 17:28:08 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id 9so5160506pll.6 for ; Thu, 03 Mar 2022 09:28:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ucEA3J1ya4GRs+I0A0pxTRPbekYvscFzYo/razXDByg=; b=Z0uYSem8nCEuzkLQw4trl/0KBRyeSAZdP+h9TK9qjKeFB7hJVjfN6qYzPVvZCWUsix GMKeMh8GMvp1HIO4vK85RsmY2JcqYXSfEt2sL2d1pZ+tAnb+3/NLiEJKmLTsBn2QYk8M UaCwZ/3Z1UXG/seNFK/fjDU0v04eieZak7kLA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ucEA3J1ya4GRs+I0A0pxTRPbekYvscFzYo/razXDByg=; b=6luGqlqIqmGXa0hqVGQmH2QG4i/K97EZRoGdN7CihiLsZ+K8VJdmo7CaN59yvTxQAq TFVgHe0HGjMvTOGopNPrXs2Wt2QPuWhBUSoBSJiqAl+00lMYb3kGsmvrBXKHnFoUkSTE xqErFBUw8JCBOME8PmK8sjdrlav2LvamIcqDIar+GzlzRCGKhuuxPCbr3UL6cTkwHOzf 1xWwWt/QL0O/+B8hQWv/FtAzpObOYqADLpdSqRZ7xQ4mPSXMhtsrwjDzEcfztfKNcmMS 7z7tCk389CBFRKK5fxv5OvVNpm4/wWEfM2K2S8FtHD55ZuytGT5vx9Sb7V03FaOWovYR QItA== X-Gm-Message-State: AOAM532W/n5+L4uxGRk52+iWQXS78+dbgTRziIdo6iQOHnHE3SCHu4k7 q7dNkM+XwpG2PFQYGFJQzuaySQ== X-Google-Smtp-Source: ABdhPJy2mzFw4jO2AzK0JYWGiB+koyjvh1Dy0wGqm4Vkn9fhv16PKbXZ5sesO86D7nyMcNXd9iCe1Q== X-Received: by 2002:a17:902:d4cc:b0:151:3857:817b with SMTP id o12-20020a170902d4cc00b001513857817bmr31774133plg.139.1646328487821; Thu, 03 Mar 2022 09:28:07 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s9-20020a056a00194900b004e1583f88a2sm3050692pfk.0.2022.03.03.09.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 09:28:07 -0800 (PST) Date: Thu, 3 Mar 2022 09:28:04 -0800 From: Kees Cook To: Greg KH Cc: David Gow , "Gustavo A. R. Silva" , Nathan Chancellor , Nick Desaulniers , Rasmus Villemoes , Vitor Massaru Iha , Daniel Latypov , Anton Ivanov , Jeff Dike , Richard Weinberger , Masahiro Yamada , Arnd Bergmann , Linux Kernel Mailing List , linux-um , linux-kbuild@vger.kernel.org, KUnit Development , llvm@lists.linux.dev, x86@kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v3 7/7] UAPI: Introduce KUnit userspace compatibility Message-ID: <202203030927.2D794F4@keescook> References: <20220227184517.504931-1-keescook@chromium.org> <20220227184517.504931-8-keescook@chromium.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 03, 2022 at 02:05:56PM +0100, Greg KH wrote: > On Thu, Mar 03, 2022 at 04:27:13PM +0800, David Gow wrote: > > On Mon, Feb 28, 2022 at 2:45 AM Kees Cook wrote: > > > diff --git a/include/uapi/misc/kunit.h b/include/uapi/misc/kunit.h > > > new file mode 100644 > > > index 000000000000..afdffda583ae > > > --- /dev/null > > > +++ b/include/uapi/misc/kunit.h > > > @@ -0,0 +1,181 @@ > > > +#ifndef __UAPI_MISC_KUNIT_H__ > > > +#define __UAPI_MISC_KUNIT_H__ > > > +/* > > > + * This is a light-weight userspace drop-in replacement for the in-kernel > > > > Someone forgot a SPDX license line for the new file. Didn't checkpatch > complain about this? :( Yeah, that file has a bunch of problems. ;) The UAPI header checking logic also freaks out, etc, etc. I'll being fixing that and the other issues. -- Kees Cook