Re: [PATCH v2 05/10] spi: aspeed: Add support for direct mapping

Re: [PATCH v2 05/10] spi: aspeed: Add support for direct mapping

[kernel test robot]

Hi "Cédric,

I love your patch! Yet something to improve:

[auto build test ERROR on mtd/spi-nor/next]
[also build test ERROR on joel-aspeed/for-next v5.17-rc6 next-20220302]
[cannot apply to broonie-spi/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/C-dric-Le-Goater/spi-spi-mem-Add-driver-for-Aspeed-SMC-controllers/20220303-013538
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next
config: arm64-randconfig-r023-20220303 (https://download.01.org/0day-ci/archive/20220303/202203031902.e9vpKoAW-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/a107d6ec2c4377b805efb71d3ab7921d7a7e61a2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review C-dric-Le-Goater/spi-spi-mem-Add-driver-for-Aspeed-SMC-controllers/20220303-013538
        git checkout a107d6ec2c4377b805efb71d3ab7921d7a7e61a2
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/spi/spi-aspeed-smc.c:474:17: error: incompatible function pointer types initializing 'ssize_t (*)(struct spi_mem_dirmap_desc *, u64, size_t, void *)' (aka 'long (*)(struct spi_mem_dirmap_desc *, unsigned long long, unsigned long, void *)') with an expression of type 'int (struct spi_mem_dirmap_desc *, u64, size_t, void *)' (aka 'int (struct spi_mem_dirmap_desc *, unsigned long long, unsigned long, void *)') [-Werror,-Wincompatible-function-pointer-types]
           .dirmap_read = aspeed_spi_dirmap_read,
                          ^~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +474 drivers/spi/spi-aspeed-smc.c

   468	
   469	static const struct spi_controller_mem_ops aspeed_spi_mem_ops = {
   470		.supports_op = aspeed_spi_supports_op,
   471		.exec_op = aspeed_spi_exec_op,
   472		.get_name = aspeed_spi_get_name,
   473		.dirmap_create = aspeed_spi_dirmap_create,
 > 474		.dirmap_read = aspeed_spi_dirmap_read,
   475	};
   476	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org