Re: [PATCH v8 08/13] media: atmel: atmel-isc: change format propagation to subdev into only verification

Re: [PATCH v8 08/13] media: atmel: atmel-isc: change format propagation to subdev into only verification

[kernel test robot]

Hi Eugen,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on next-20220309]
[cannot apply to robh/for-next linux/master linus/master v5.17-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Eugen-Hristev/media-atmel-atmel-isc-implement-media-controller/20220310-010819
base:   git://linuxtv.org/media_tree.git master
config: arm64-randconfig-r011-20220309 (https://download.01.org/0day-ci/archive/20220310/202203100702.sKbUGmsv-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 276ca87382b8f16a65bddac700202924228982f6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/9309e70b1b6779814e915f8e103048c6681f280f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eugen-Hristev/media-atmel-atmel-isc-implement-media-controller/20220310-010819
        git checkout 9309e70b1b6779814e915f8e103048c6681f280f
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/media/platform/atmel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/platform/atmel/atmel-isc-base.c:1955:5: warning: no previous prototype for function 'isc_link_validate' [-Wmissing-prototypes]
   int isc_link_validate(struct media_link *link)
       ^
   drivers/media/platform/atmel/atmel-isc-base.c:1955:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int isc_link_validate(struct media_link *link)
   ^
   static 
   1 warning generated.


vim +/isc_link_validate +1955 drivers/media/platform/atmel/atmel-isc-base.c

  1954	
> 1955	int isc_link_validate(struct media_link *link)
  1956	{
  1957		struct video_device *vdev =
  1958			media_entity_to_video_device(link->sink->entity);
  1959		struct isc_device *isc = video_get_drvdata(vdev);
  1960		int ret;
  1961	
  1962		ret = v4l2_subdev_link_validate(link);
  1963		if (ret)
  1964			return ret;
  1965	
  1966		return isc_validate(isc);
  1967	}
  1968	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org