From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881D87E
	for <llvm@lists.linux.dev>; Fri, 11 Mar 2022 01:52:17 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7C67C340E8;
	Fri, 11 Mar 2022 01:52:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1646963537;
	bh=2Gke8hh3aIhj9iTkxhpQghxW0+aYsJifVXn4KB8RgQY=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=XGekMziLl59NDO8JIAbgZiw2jhRA9ZtLzNZDJb2liZKXKA0C4dovTLBI1D9lg8Ct8
	 lVnjqvriGUWQBOqfbKY8YFNYF7LrXRprhxODCRRFgmmPqnpCu5ec6+aL3w5Y3OcZ6q
	 a4YmwV9WrQIiWolOegSe2xs0R3gW9/sdvQoXo8eg=
Date: Thu, 10 Mar 2022 17:52:16 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Nathan Chancellor <nathan@kernel.org>,
 Nick Desaulniers <ndesaulniers@google.com>, "Michael S . Tsirkin"
 <mst@redhat.com>, llvm@lists.linux.dev, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 1/2] linux/types.h: Remove unnecessary __bitwise__
Message-Id: <20220310175216.252fabefeca040004216d40d@linux-foundation.org>
In-Reply-To: <20220310220927.245704-2-helgaas@kernel.org>
References: <20220310220927.245704-1-helgaas@kernel.org>
	<20220310220927.245704-2-helgaas@kernel.org>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu)
Precedence: bulk
X-Mailing-List: llvm@lists.linux.dev
List-Id: <llvm.lists.linux.dev>
List-Subscribe: <mailto:llvm+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:llvm+unsubscribe@lists.linux.dev>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 10 Mar 2022 16:09:26 -0600 Bjorn Helgaas <helgaas@kernel.org> wrote:

> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> There are no users of "__bitwise__" except the definition of "__bitwise".
> Remove __bitwise__ and define __bitwise directly.
> 
> This is a follow-up to 05de97003c77 ("linux/types.h: enable endian checks
> for all sparse builds").
> 

Can we change the copy-pasted code in tools/include/linux/types.h while
we're there?


--- a/tools/include/linux/types.h~linux-typesh-remove-unnecessary-__bitwise__-fix
+++ a/tools/include/linux/types.h
@@ -43,11 +43,10 @@ typedef __u8  u8;
 typedef __s8  s8;
 
 #ifdef __CHECKER__
-#define __bitwise__ __attribute__((bitwise))
+#define __bitwise	__attribute__((bitwise))
 #else
-#define __bitwise__
+#define __bitwise
 #endif
-#define __bitwise __bitwise__
 
 #define __force
 #define __user
_