* Re: [PATCH v2 8/8] media: i2c: ov5670: Add .get_selection() support
[not found] <20220314162714.153970-9-jacopo@jmondi.org>
@ 2022-03-15 4:18 ` kernel test robot
2022-03-15 16:55 ` Nathan Chancellor
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-03-15 4:18 UTC (permalink / raw)
To: Jacopo Mondi, Chiranjeevi Rapolu
Cc: llvm, kbuild-all, Jacopo Mondi, krzysztof.kozlowski,
jeanmichel.hautbois, laurent.pinchart, paul.kocialkowski,
sakari.ailus, paul.elder, Mauro Carvalho Chehab, linux-media
Hi Jacopo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on media-tree/master]
[also build test ERROR on linus/master v5.17-rc8 next-20220310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jacopo-Mondi/media-i2c-ov5670-OF-support-runtime_pm-regulators/20220315-003034
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-a012-20220314 (https://download.01.org/0day-ci/archive/20220315/202203151238.pCKNarov-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 3e4950d7fa78ac83f33bbf1658e2f49a73719236)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c619a8eee6477517dfaa05511344d0bddc4e1c55
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jacopo-Mondi/media-i2c-ov5670-OF-support-runtime_pm-regulators/20220315-003034
git checkout c619a8eee6477517dfaa05511344d0bddc4e1c55
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/media/i2c/ov5670.c:1787:18: error: initializer element is not a compile-time constant
.analog_crop = ov5670_analog_crop,
^~~~~~~~~~~~~~~~~~
1 error generated.
vim +1787 drivers/media/i2c/ov5670.c
1774
1775 /*
1776 * OV5670 sensor supports following resolutions with full FOV:
1777 * 4:3 ==> {2592x1944, 1296x972, 648x486}
1778 * 16:9 ==> {2560x1440, 1280x720, 640x360}
1779 */
1780 static const struct ov5670_mode supported_modes[] = {
1781 {
1782 .width = 2592,
1783 .height = 1944,
1784 .vts_def = OV5670_VTS_30FPS,
1785 .vts_min = OV5670_VTS_30FPS,
1786 .link_freq_index = OV5670_LINK_FREQ_422MHZ_INDEX,
> 1787 .analog_crop = ov5670_analog_crop,
1788 .reg_list = {
1789 .num_of_regs = ARRAY_SIZE(mode_2592x1944_regs),
1790 .regs = mode_2592x1944_regs,
1791 },
1792 },
1793 {
1794 .width = 1296,
1795 .height = 972,
1796 .vts_def = OV5670_VTS_30FPS,
1797 .vts_min = 996,
1798 .link_freq_index = OV5670_LINK_FREQ_422MHZ_INDEX,
1799 .analog_crop = ov5670_analog_crop,
1800 .reg_list = {
1801 .num_of_regs = ARRAY_SIZE(mode_1296x972_regs),
1802 .regs = mode_1296x972_regs,
1803 },
1804 },
1805 {
1806 .width = 648,
1807 .height = 486,
1808 .vts_def = OV5670_VTS_30FPS,
1809 .vts_min = 516,
1810 .link_freq_index = OV5670_LINK_FREQ_422MHZ_INDEX,
1811 .analog_crop = ov5670_analog_crop,
1812 .reg_list = {
1813 .num_of_regs = ARRAY_SIZE(mode_648x486_regs),
1814 .regs = mode_648x486_regs,
1815 },
1816 },
1817 {
1818 .width = 2560,
1819 .height = 1440,
1820 .vts_def = OV5670_VTS_30FPS,
1821 .vts_min = OV5670_VTS_30FPS,
1822 .link_freq_index = OV5670_LINK_FREQ_422MHZ_INDEX,
1823 .analog_crop = ov5670_analog_crop,
1824 .reg_list = {
1825 .num_of_regs = ARRAY_SIZE(mode_2560x1440_regs),
1826 .regs = mode_2560x1440_regs,
1827 },
1828 },
1829 {
1830 .width = 1280,
1831 .height = 720,
1832 .vts_def = OV5670_VTS_30FPS,
1833 .vts_min = 1020,
1834
1835 .link_freq_index = OV5670_LINK_FREQ_422MHZ_INDEX,
1836 .analog_crop = ov5670_analog_crop,
1837 .reg_list = {
1838 .num_of_regs = ARRAY_SIZE(mode_1280x720_regs),
1839 .regs = mode_1280x720_regs,
1840 },
1841 },
1842 {
1843 .width = 640,
1844 .height = 360,
1845 .vts_def = OV5670_VTS_30FPS,
1846 .vts_min = 510,
1847 .link_freq_index = OV5670_LINK_FREQ_422MHZ_INDEX,
1848 .analog_crop = ov5670_analog_crop,
1849 .reg_list = {
1850 .num_of_regs = ARRAY_SIZE(mode_640x360_regs),
1851 .regs = mode_640x360_regs,
1852 },
1853 }
1854 };
1855
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 8/8] media: i2c: ov5670: Add .get_selection() support
2022-03-15 4:18 ` [PATCH v2 8/8] media: i2c: ov5670: Add .get_selection() support kernel test robot
@ 2022-03-15 16:55 ` Nathan Chancellor
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Chancellor @ 2022-03-15 16:55 UTC (permalink / raw)
To: kernel test robot
Cc: Jacopo Mondi, Chiranjeevi Rapolu, llvm, kbuild-all,
krzysztof.kozlowski, jeanmichel.hautbois, laurent.pinchart,
paul.kocialkowski, sakari.ailus, paul.elder,
Mauro Carvalho Chehab, linux-media
On Tue, Mar 15, 2022 at 12:18:48PM +0800, kernel test robot wrote:
> Hi Jacopo,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on media-tree/master]
> [also build test ERROR on linus/master v5.17-rc8 next-20220310]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Jacopo-Mondi/media-i2c-ov5670-OF-support-runtime_pm-regulators/20220315-003034
> base: git://linuxtv.org/media_tree.git master
> config: i386-randconfig-a012-20220314 (https://download.01.org/0day-ci/archive/20220315/202203151238.pCKNarov-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 3e4950d7fa78ac83f33bbf1658e2f49a73719236)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/c619a8eee6477517dfaa05511344d0bddc4e1c55
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Jacopo-Mondi/media-i2c-ov5670-OF-support-runtime_pm-regulators/20220315-003034
> git checkout c619a8eee6477517dfaa05511344d0bddc4e1c55
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> >> drivers/media/i2c/ov5670.c:1787:18: error: initializer element is not a compile-time constant
> .analog_crop = ov5670_analog_crop,
> ^~~~~~~~~~~~~~~~~~
> 1 error generated.
GCC versions prior to 8 will complain about this as well:
$ gcc --version | head -1
gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
$ make -j"$(nproc)" mrproper allmodconfig drivers/media/i2c/ov5670.o
drivers/media/i2c/ov5670.c:1787:18: error: initializer element is not constant
.analog_crop = ov5670_analog_crop,
^~~~~~~~~~~~~~~~~~
drivers/media/i2c/ov5670.c:1787:18: note: (near initialization for ‘supported_modes[0].analog_crop’)
drivers/media/i2c/ov5670.c:1799:18: error: initializer element is not constant
.analog_crop = ov5670_analog_crop,
^~~~~~~~~~~~~~~~~~
drivers/media/i2c/ov5670.c:1799:18: note: (near initialization for ‘supported_modes[1].analog_crop’)
drivers/media/i2c/ov5670.c:1811:18: error: initializer element is not constant
.analog_crop = ov5670_analog_crop,
^~~~~~~~~~~~~~~~~~
drivers/media/i2c/ov5670.c:1811:18: note: (near initialization for ‘supported_modes[2].analog_crop’)
drivers/media/i2c/ov5670.c:1823:18: error: initializer element is not constant
.analog_crop = ov5670_analog_crop,
^~~~~~~~~~~~~~~~~~
drivers/media/i2c/ov5670.c:1823:18: note: (near initialization for ‘supported_modes[3].analog_crop’)
drivers/media/i2c/ov5670.c:1836:18: error: initializer element is not constant
.analog_crop = ov5670_analog_crop,
^~~~~~~~~~~~~~~~~~
drivers/media/i2c/ov5670.c:1836:18: note: (near initialization for ‘supported_modes[4].analog_crop’)
drivers/media/i2c/ov5670.c:1848:18: error: initializer element is not constant
.analog_crop = ov5670_analog_crop,
^~~~~~~~~~~~~~~~~~
drivers/media/i2c/ov5670.c:1848:18: note: (near initialization for ‘supported_modes[5].analog_crop’)
scripts/Makefile.build:288: recipe for target 'drivers/media/i2c/ov5670.o' failed
clang may eventually support this: https://reviews.llvm.org/D76096
Cheers,
Nathan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-15 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220314162714.153970-9-jacopo@jmondi.org>
2022-03-15 4:18 ` [PATCH v2 8/8] media: i2c: ov5670: Add .get_selection() support kernel test robot
2022-03-15 16:55 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox