Re: [PATCH v2 1/2] Simplify XFS logging methods.

Re: [PATCH v2 1/2] Simplify XFS logging methods.

[kernel test robot]

Hi Jonathan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on 34af78c4e616c359ed428d79fe4758a35d2c5473]

url:    https://github.com/0day-ci/linux/commits/Jonathan-Lassoff/Simplify-XFS-logging-methods/20220325-153845
base:   34af78c4e616c359ed428d79fe4758a35d2c5473
config: x86_64-randconfig-a003 (https://download.01.org/0day-ci/archive/20220325/202203252101.MF3tnkGK-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0f6d9501cf49ce02937099350d08f20c4af86f3d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2990fe0fadf416670e325c2bbc0648bf45861439
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jonathan-Lassoff/Simplify-XFS-logging-methods/20220325-153845
        git checkout 2990fe0fadf416670e325c2bbc0648bf45861439
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from fs/xfs/kmem.c:6:
   In file included from fs/xfs/xfs.h:22:
   In file included from fs/xfs/xfs_linux.h:81:
>> fs/xfs/xfs_message.h:13:23: error: expected ';' after top level declarator
           const char *fmt, ...)
                                ^
                                ;
   1 error generated.
--
   In file included from fs/xfs/xfs_log_recover.c:6:
   In file included from fs/xfs/xfs.h:22:
   In file included from fs/xfs/xfs_linux.h:81:
>> fs/xfs/xfs_message.h:13:23: error: expected ';' after top level declarator
           const char *fmt, ...)
                                ^
                                ;
   fs/xfs/xfs_log_recover.c:3550:12: warning: variable 'ifree' set but not used [-Wunused-but-set-variable]
           uint64_t                ifree;
                                   ^
   fs/xfs/xfs_log_recover.c:3549:12: warning: variable 'itotal' set but not used [-Wunused-but-set-variable]
           uint64_t                itotal;
                                   ^
   fs/xfs/xfs_log_recover.c:3548:12: warning: variable 'freeblks' set but not used [-Wunused-but-set-variable]
           uint64_t                freeblks;
                                   ^
   3 warnings and 1 error generated.
--
   In file included from fs/xfs/libxfs/xfs_bmap.c:6:
   In file included from fs/xfs/xfs.h:22:
   In file included from fs/xfs/xfs_linux.h:81:
>> fs/xfs/xfs_message.h:13:23: error: expected ';' after top level declarator
           const char *fmt, ...)
                                ^
                                ;
   fs/xfs/libxfs/xfs_bmap.c:5059:18: warning: variable 'bno' set but not used [-Wunused-but-set-variable]
                           xfs_fsblock_t   bno;
                                           ^
   1 warning and 1 error generated.
--
   In file included from fs/xfs/xfs_file.c:6:
   In file included from fs/xfs/xfs.h:22:
   In file included from fs/xfs/xfs_linux.h:81:
>> fs/xfs/xfs_message.h:13:23: error: expected ';' after top level declarator
           const char *fmt, ...)
                                ^
                                ;
   In file included from fs/xfs/xfs_file.c:30:
   include/linux/mman.h:158:9: warning: division by zero is undefined [-Wdivision-by-zero]
                  _calc_vm_trans(flags, MAP_SYNC,       VM_SYNC      ) |
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/mman.h:136:21: note: expanded from macro '_calc_vm_trans'
      : ((x) & (bit1)) / ((bit1) / (bit2))))
                       ^ ~~~~~~~~~~~~~~~~~
   1 warning and 1 error generated.


vim +13 fs/xfs/xfs_message.h

     8	
     9	extern __printf(3, 4)
    10	void xfs_printk_level(
    11		const char *kern_level,
    12		const struct xfs_mount *mp,
  > 13		const char *fmt, ...)
    14	#define xfs_emerg(mp, fmt, ...) \
    15		xfs_printk_level(KERN_EMERG, mp, fmt, ##__VA_ARGS__)
    16	#define xfs_alert(mp, fmt, ...) \
    17		xfs_printk_level(KERN_ALERT, mp, fmt, ##__VA_ARGS__)
    18	#define xfs_crit(mp, fmt, ...) \
    19		xfs_printk_level(KERN_CRIT, mp, fmt, ##__VA_ARGS__)
    20	#define xfs_err(mp, fmt, ...) \
    21		xfs_printk_level(KERN_ERR, mp, fmt, ##__VA_ARGS__)
    22	#define xfs_warn(mp, fmt, ...) \
    23		xfs_printk_level(KERN_WARNING, mp, fmt, ##__VA_ARGS__)
    24	#define xfs_notice(mp, fmt, ...) \
    25		xfs_printk_level(KERN_NOTICE, mp, fmt, ##__VA_ARGS__)
    26	#define xfs_info(mp, fmt, ...) \
    27		xfs_printk_level(KERN_INFO, mp, fmt, ##__VA_ARGS__)
    28	#ifdef DEBUG
    29	#define xfs_debug(mp, fmt, ...) \
    30		xfs_printk_level(KERN_DEBUG, mp, fmt, ##__VA_ARGS__)
    31	#else
    32	#define xfs_debug(mp, fmt, ...) do {} while (0)
    33	#endif
    34	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp