* Re: [RFC PATCH 3/4] mptcp: never shrink offered window
[not found] <ab1fd2897c57a50d7580950dbe6fb58006c04253.1649672265.git.pabeni@redhat.com>
@ 2022-04-11 18:23 ` kernel test robot
2022-04-11 19:46 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-04-11 18:23 UTC (permalink / raw)
To: Paolo Abeni; +Cc: llvm, kbuild-all
Hi Paolo,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on mptcp/export]
[also build test ERROR on linus/master v5.18-rc2 next-20220411]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Paolo-Abeni/mptcp-improve-mptcp-level-window-tracking/20220411-184144
base: https://github.com/multipath-tcp/mptcp_net-next.git export
config: hexagon-defconfig (https://download.01.org/0day-ci/archive/20220412/202204120247.mC6ZORgL-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c6e83f560f06cdfe8aa47b248d8bdc58f947274b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4cd25cbca4acc18a428817e9b1adc5ddd131422b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Paolo-Abeni/mptcp-improve-mptcp-level-window-tracking/20220411-184144
git checkout 4cd25cbca4acc18a428817e9b1adc5ddd131422b
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/mptcp/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/mptcp/options.c:554:21: warning: parameter 'remaining' set but not used [-Wunused-but-set-parameter]
unsigned int remaining,
^
>> net/mptcp/options.c:1248:14: error: implicit declaration of function 'arch_cmpxchg64' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
rcv_wnd = cmpxchg64(&msk->rcv_wnd_sent, rcv_wnd_old, rcv_wnd_new);
^
include/linux/atomic/atomic-instrumented.h:1946:2: note: expanded from macro 'cmpxchg64'
arch_cmpxchg64(__ai_ptr, __VA_ARGS__); \
^
1 warning and 1 error generated.
vim +/arch_cmpxchg64 +1248 net/mptcp/options.c
1226
1227 static void mptcp_set_rwin(struct tcp_sock *tp, void *opt)
1228 {
1229 const struct sock *ssk = (const struct sock *)tp;
1230 struct mptcp_subflow_context *subflow;
1231 u64 ack_seq, rcv_wnd_old, rcv_wnd_new;
1232 struct mptcp_sock *msk;
1233 struct tcphdr *th;
1234 u32 new_win;
1235 u64 win;
1236
1237 subflow = mptcp_subflow_ctx(ssk);
1238 msk = mptcp_sk(subflow->conn);
1239
1240 ack_seq = READ_ONCE(msk->ack_seq);
1241 rcv_wnd_new = ack_seq + tp->rcv_wnd;
1242
1243 rcv_wnd_old = READ_ONCE(msk->rcv_wnd_sent);
1244 if (after64(rcv_wnd_new, rcv_wnd_old)) {
1245 u64 rcv_wnd;
1246
1247 for (;;) {
> 1248 rcv_wnd = cmpxchg64(&msk->rcv_wnd_sent, rcv_wnd_old, rcv_wnd_new);
1249
1250 if (rcv_wnd == rcv_wnd_old)
1251 break;
1252 if (before64(rcv_wnd_new, rcv_wnd))
1253 goto raise_win;
1254 rcv_wnd_old = rcv_wnd;
1255 };
1256 return;
1257 }
1258
1259 if (rcv_wnd_new != rcv_wnd_old) {
1260
1261 raise_win:
1262 th = opt - sizeof(struct tcphdr);
1263 win = rcv_wnd_old - ack_seq;
1264 tp->rcv_wnd = min_t(u64, win, U32_MAX);
1265 new_win = tp->rcv_wnd;
1266
1267 /* Make sure we do not exceed the maximum possible
1268 * scaled window.
1269 */
1270 if (unlikely(th->syn))
1271 new_win = min(new_win, 65535U) << tp->rx_opt.rcv_wscale;
1272 if (!tp->rx_opt.rcv_wscale &&
1273 sock_net(ssk)->ipv4.sysctl_tcp_workaround_signed_windows)
1274 new_win = min(new_win, MAX_TCP_WINDOW);
1275 else
1276 new_win = min(new_win, (65535U << tp->rx_opt.rcv_wscale));
1277
1278 /* RFC1323 scaling applied */
1279 new_win >>= tp->rx_opt.rcv_wscale;
1280 th->window = htons(new_win);
1281 }
1282 }
1283
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RFC PATCH 3/4] mptcp: never shrink offered window
[not found] <ab1fd2897c57a50d7580950dbe6fb58006c04253.1649672265.git.pabeni@redhat.com>
2022-04-11 18:23 ` [RFC PATCH 3/4] mptcp: never shrink offered window kernel test robot
@ 2022-04-11 19:46 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-04-11 19:46 UTC (permalink / raw)
To: Paolo Abeni; +Cc: llvm, kbuild-all
Hi Paolo,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on mptcp/export]
[also build test ERROR on linus/master v5.18-rc2 next-20220411]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Paolo-Abeni/mptcp-improve-mptcp-level-window-tracking/20220411-184144
base: https://github.com/multipath-tcp/mptcp_net-next.git export
config: arm-buildonly-randconfig-r006-20220411 (https://download.01.org/0day-ci/archive/20220412/202204120334.WqEBThyK-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c6e83f560f06cdfe8aa47b248d8bdc58f947274b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/intel-lab-lkp/linux/commit/4cd25cbca4acc18a428817e9b1adc5ddd131422b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Paolo-Abeni/mptcp-improve-mptcp-level-window-tracking/20220411-184144
git checkout 4cd25cbca4acc18a428817e9b1adc5ddd131422b
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash net/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/mptcp/options.c:554:21: warning: parameter 'remaining' set but not used [-Wunused-but-set-parameter]
unsigned int remaining,
^
In file included from net/mptcp/options.c:9:
In file included from include/linux/kernel.h:22:
In file included from include/linux/bitops.h:33:
In file included from arch/arm/include/asm/bitops.h:243:
In file included from include/asm-generic/bitops/lock.h:5:
In file included from include/linux/atomic.h:7:
In file included from arch/arm/include/asm/atomic.h:16:
>> arch/arm/include/asm/cmpxchg.h:254:1: error: instruction requires: !armv*m
"1: ldrexd %1, %H1, [%3]\n"
^
<inline asm>:1:5: note: instantiated into assembly here
1: ldrexd r8, r9, [r11]
^
In file included from net/mptcp/options.c:9:
In file included from include/linux/kernel.h:22:
In file included from include/linux/bitops.h:33:
In file included from arch/arm/include/asm/bitops.h:243:
In file included from include/asm-generic/bitops/lock.h:5:
In file included from include/linux/atomic.h:7:
In file included from arch/arm/include/asm/atomic.h:16:
arch/arm/include/asm/cmpxchg.h:258:2: error: instruction requires: !armv*m
" strexd %0, %5, %H5, [%3]\n"
^
<inline asm>:5:2: note: instantiated into assembly here
strexd r0, r4, r5, [r11]
^
1 warning and 2 errors generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for DRM_GEM_SHMEM_HELPER
Depends on HAS_IOMEM && DRM && MMU
Selected by
- DRM_SSD130X && HAS_IOMEM && DRM
vim +254 arch/arm/include/asm/cmpxchg.h
e001bbae7147b1 Russell King 2015-05-26 243
2523c67bb6962f Will Deacon 2013-10-09 244 static inline unsigned long long __cmpxchg64(unsigned long long *ptr,
2523c67bb6962f Will Deacon 2013-10-09 245 unsigned long long old,
2523c67bb6962f Will Deacon 2013-10-09 246 unsigned long long new)
2523c67bb6962f Will Deacon 2013-10-09 247 {
2523c67bb6962f Will Deacon 2013-10-09 248 unsigned long long oldval;
2523c67bb6962f Will Deacon 2013-10-09 249 unsigned long res;
2523c67bb6962f Will Deacon 2013-10-09 250
c32ffce0f66e5d Will Deacon 2014-02-21 251 prefetchw(ptr);
c32ffce0f66e5d Will Deacon 2014-02-21 252
2523c67bb6962f Will Deacon 2013-10-09 253 __asm__ __volatile__(
2523c67bb6962f Will Deacon 2013-10-09 @254 "1: ldrexd %1, %H1, [%3]\n"
2523c67bb6962f Will Deacon 2013-10-09 255 " teq %1, %4\n"
2523c67bb6962f Will Deacon 2013-10-09 256 " teqeq %H1, %H4\n"
2523c67bb6962f Will Deacon 2013-10-09 257 " bne 2f\n"
2523c67bb6962f Will Deacon 2013-10-09 258 " strexd %0, %5, %H5, [%3]\n"
2523c67bb6962f Will Deacon 2013-10-09 259 " teq %0, #0\n"
2523c67bb6962f Will Deacon 2013-10-09 260 " bne 1b\n"
2523c67bb6962f Will Deacon 2013-10-09 261 "2:"
2523c67bb6962f Will Deacon 2013-10-09 262 : "=&r" (res), "=&r" (oldval), "+Qo" (*ptr)
2523c67bb6962f Will Deacon 2013-10-09 263 : "r" (ptr), "r" (old), "r" (new)
2523c67bb6962f Will Deacon 2013-10-09 264 : "cc");
2523c67bb6962f Will Deacon 2013-10-09 265
2523c67bb6962f Will Deacon 2013-10-09 266 return oldval;
2523c67bb6962f Will Deacon 2013-10-09 267 }
2523c67bb6962f Will Deacon 2013-10-09 268
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread