* Re: [PATCH 2/2] io_uring: add socket(2) support
[not found] <20220412202240.234207-3-axboe@kernel.dk>
@ 2022-04-13 11:09 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-04-13 11:09 UTC (permalink / raw)
To: Jens Axboe; +Cc: llvm, kbuild-all
Hi Jens,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20220412]
[cannot apply to horms-ipvs/master net/master net-next/master linus/master v5.18-rc2 v5.18-rc1 v5.17 v5.18-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Jens-Axboe/Add-io_uring-socket-2-support/20220413-050345
base: d0c745e7b2d6ce8bcc768b32361ab8ef520821ee
config: arm64-buildonly-randconfig-r001-20220413 (https://download.01.org/0day-ci/archive/20220413/202204131949.Vft3PfEM-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/8f4e27a291c192076d65f71fcaf34d1b30b892f7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jens-Axboe/Add-io_uring-socket-2-support/20220413-050345
git checkout 8f4e27a291c192076d65f71fcaf34d1b30b892f7
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> fs/io_uring.c:5962:3: error: implicit declaration of function 'io_sock_nolock_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
io_sock_nolock_set(file);
^
1 error generated.
vim +/io_sock_nolock_set +5962 fs/io_uring.c
5935
5936 static int io_socket(struct io_kiocb *req, unsigned int issue_flags)
5937 {
5938 struct io_socket *sock = &req->sock;
5939 bool fixed = !!sock->file_slot;
5940 struct file *file;
5941 int ret, fd;
5942
5943 if (!fixed) {
5944 fd = __get_unused_fd_flags(sock->flags, sock->nofile);
5945 if (unlikely(fd < 0))
5946 return fd;
5947 }
5948 file = __sys_socket_file(sock->domain, sock->type, sock->protocol);
5949 if (IS_ERR(file)) {
5950 if (!fixed)
5951 put_unused_fd(fd);
5952 ret = PTR_ERR(file);
5953 if (ret == -EAGAIN && (issue_flags & IO_URING_F_NONBLOCK))
5954 return -EAGAIN;
5955 if (ret == -ERESTARTSYS)
5956 ret = -EINTR;
5957 req_set_fail(req);
5958 } else if (!fixed) {
5959 fd_install(fd, file);
5960 ret = fd;
5961 } else {
> 5962 io_sock_nolock_set(file);
5963 ret = io_install_fixed_file(req, file, issue_flags,
5964 sock->file_slot - 1);
5965 }
5966 __io_req_complete(req, issue_flags, ret, 0);
5967 return 0;
5968 }
5969
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread