From: Tom Rix <trix@redhat.com>
To: broonie@kernel.org, nathan@kernel.org, ndesaulniers@google.com,
paul.kocialkowski@bootlin.com
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Tom Rix <trix@redhat.com>
Subject: [PATCH] spi: initialize status to success
Date: Sat, 16 Apr 2022 16:51:32 -0400 [thread overview]
Message-ID: <20220416205132.295779-1-trix@redhat.com> (raw)
Clang static analysis reports this issue
spi.c:3583:2: warning: 2nd function call argument
is an uninitialized value
trace_spi_setup(spi, status);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
It is possible that status is never set because
its function level setting was removed by the
commit listed in the Fixes: tag.
Assume that setting 8 bits-per-word is ok and
initialize the status to 0.
Fixes: b3fe2e516741 ("spi: core: Only check bits_per_word validity when explicitly provided")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/spi/spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 563a56ce34a0..890ff46c784a 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -3475,7 +3475,7 @@ static int __spi_validate_bits_per_word(struct spi_controller *ctlr,
int spi_setup(struct spi_device *spi)
{
unsigned bad_bits, ugly_bits;
- int status;
+ int status = 0;
/*
* Check mode to prevent that any two of DUAL, QUAD and NO_MOSI/MISO
--
2.27.0
next reply other threads:[~2022-04-16 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 20:51 Tom Rix [this message]
2022-04-16 23:05 ` [PATCH] spi: initialize status to success Nathan Chancellor
2022-04-17 19:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220416205132.295779-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paul.kocialkowski@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).