From: Colin Ian King <colin.i.king@gmail.com>
To: Matt Porter <mporter@kernel.crashing.org>,
Alexandre Bounine <alex.bou9@gmail.com>,
linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, llvm@lists.linux.dev
Subject: [PATCH] rapidio: Remove redundant variable tmp
Date: Mon, 18 Apr 2022 15:58:42 +0100 [thread overview]
Message-ID: <20220418145842.87154-1-colin.i.king@gmail.com> (raw)
Variable tmp is being assigned a value that is never read, the variable
is redundant and can be removed.
Cleans up clang scan build warning:
drivers/rapidio/rio-scan.c:561:10: warning: Although the value stored
to 'tmp' is used in the enclosing expression, the value is never actually
read from 'tmp' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/rapidio/rio-scan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rapidio/rio-scan.c b/drivers/rapidio/rio-scan.c
index 19b0c33f4a62..5256e76ab29c 100644
--- a/drivers/rapidio/rio-scan.c
+++ b/drivers/rapidio/rio-scan.c
@@ -524,7 +524,6 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
{
struct rio_dev *rdev;
u32 regval;
- int tmp;
if (rio_mport_chk_dev_access(port,
RIO_ANY_DESTID(port->sys_size), hopcount)) {
@@ -558,8 +557,7 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
rio_mport_write_config_32(port, RIO_ANY_DESTID(port->sys_size),
hopcount,
RIO_HOST_DID_LOCK_CSR, port->host_deviceid);
- while ((tmp = rio_get_host_deviceid_lock(port, hopcount))
- < port->host_deviceid) {
+ while (rio_get_host_deviceid_lock(port, hopcount) < port->host_deviceid) {
/* Delay a bit */
mdelay(1);
/* Attempt to acquire device lock again */
--
2.35.1
reply other threads:[~2022-04-18 14:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220418145842.87154-1-colin.i.king@gmail.com \
--to=colin.i.king@gmail.com \
--cc=alex.bou9@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).