From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A961C1365 for ; Wed, 20 Apr 2022 09:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650446250; x=1681982250; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ALSkC4Dl0w89PKZV5w9BwHLZswIiZF/b1MyNqhvzPBM=; b=LDIr58lZpPPkbd3uyyQkoqqijdpXzCWe1mxTZHhtspv4kdXzU/xkVSiN GcnhRbs+CpE7WbEXdkVgTJYDNm7Zcx+eyuN1ZLxvaya2m/PzsbIA3Qsed /h/nyJToNtc38FP/FGcHUNW9Y4lul/4QDYEjJ1hm5UZ3OnMFpFHvU4V2J /tGS3IDq04Emq89buOGqEXFxBjdYXiJmSPsoRHFrggyP/5H/mRe1pxpiM C6MRJkknf0ehmhtppHukUIVT2PkJMwUiuS4T6oH6w+7Oc8Kuqwt3XolEM p1fq37QPkwEDW5KfKxbRJRV8fjl9LTSmSHfRC5uDzWvMHkBaHYd+ZZaiy A==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="264155371" X-IronPort-AV: E=Sophos;i="5.90,275,1643702400"; d="scan'208";a="264155371" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 02:17:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,275,1643702400"; d="scan'208";a="863372211" Received: from lkp-server01.sh.intel.com (HELO 3abc53900bec) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 20 Apr 2022 02:17:20 -0700 Received: from kbuild by 3abc53900bec with local (Exim 4.95) (envelope-from ) id 1nh6SY-0006oI-FV; Wed, 20 Apr 2022 09:17:14 +0000 Date: Wed, 20 Apr 2022 17:16:21 +0800 From: kernel test robot To: Karol Herbst , linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Karol Herbst , Chris Wilson Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix race in __i915_vma_remove_closed Message-ID: <202204201724.hgR7L8YU-lkp@intel.com> References: <20220419234436.2638649-1-kherbst@redhat.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419234436.2638649-1-kherbst@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Hi Karol, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v5.18-rc3 next-20220419] [cannot apply to drm-intel/for-linux-next linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Karol-Herbst/drm-i915-Fix-race-in-__i915_vma_remove_closed/20220420-074525 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220420/202204201724.hgR7L8YU-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/50a17180127b7d2527ee9a8f5c9e8207e158afb6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Karol-Herbst/drm-i915-Fix-race-in-__i915_vma_remove_closed/20220420-074525 git checkout 50a17180127b7d2527ee9a8f5c9e8207e158afb6 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/gpu/drm/i915/i915_vma.c:1654:19: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement] struct intel_gt *gt = vma->vm->gt; ^ 1 warning generated. vim +1654 drivers/gpu/drm/i915/i915_vma.c 1640 1641 static void release_references(struct i915_vma *vma, bool vm_ddestroy) 1642 { 1643 struct drm_i915_gem_object *obj = vma->obj; 1644 1645 GEM_BUG_ON(i915_vma_is_active(vma)); 1646 1647 spin_lock(&obj->vma.lock); 1648 list_del(&vma->obj_link); 1649 if (!RB_EMPTY_NODE(&vma->obj_node)) 1650 rb_erase(&vma->obj_node, &obj->vma.tree); 1651 1652 spin_unlock(&obj->vma.lock); 1653 > 1654 struct intel_gt *gt = vma->vm->gt; 1655 1656 spin_lock_irq(>->closed_lock); 1657 __i915_vma_remove_closed(vma); 1658 spin_unlock_irq(>->closed_lock); 1659 1660 if (vm_ddestroy) 1661 i915_vm_resv_put(vma->vm); 1662 1663 i915_active_fini(&vma->active); 1664 GEM_WARN_ON(vma->resource); 1665 i915_vma_free(vma); 1666 } 1667 -- 0-DAY CI Kernel Test Service https://01.org/lkp