Re: [PATCH] mm/damon/sysfs: fix pid leak under fvaddr ops use case

[kernel test robot <lkp@intel.com>]

Hi SeongJae,

I love your patch! Yet something to improve:

[auto build test ERROR on hnaz-mm/master]

url:    https://github.com/intel-lab-lkp/linux/commits/SeongJae-Park/mm-damon-sysfs-fix-pid-leak-under-fvaddr-ops-use-case/20220504-060657
base:   https://github.com/hnaz/linux-mm master
config: hexagon-randconfig-r045-20220501 (https://download.01.org/0day-ci/archive/20220504/202205041011.jv6vuDe4-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 363b3a645a1e30011cc8da624f13dac5fd915628)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/60cfe4571b04ef4ca2e34793fbad737bb43dc0c6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review SeongJae-Park/mm-damon-sysfs-fix-pid-leak-under-fvaddr-ops-use-case/20220504-060657
        git checkout 60cfe4571b04ef4ca2e34793fbad737bb43dc0c6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash mm/damon/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> mm/damon/sysfs.c:2089:20: error: use of undeclared identifier 'DAMON_OPS_FVADDR'; did you mean 'DAMON_OPS_VADDR'?
                                   ctx->ops.id == DAMON_OPS_FVADDR)
                                                  ^~~~~~~~~~~~~~~~
                                                  DAMON_OPS_VADDR
   include/linux/damon.h:267:2: note: 'DAMON_OPS_VADDR' declared here
           DAMON_OPS_VADDR,
           ^
   mm/damon/sysfs.c:2206:55: error: use of undeclared identifier 'DAMON_OPS_FVADDR'; did you mean 'DAMON_OPS_VADDR'?
           if (ctx->ops.id != DAMON_OPS_VADDR && ctx->ops.id != DAMON_OPS_FVADDR)
                                                                ^~~~~~~~~~~~~~~~
                                                                DAMON_OPS_VADDR
   include/linux/damon.h:267:2: note: 'DAMON_OPS_VADDR' declared here
           DAMON_OPS_VADDR,
           ^
   2 errors generated.


vim +2089 mm/damon/sysfs.c

  2082	
  2083	static void damon_sysfs_destroy_targets(struct damon_ctx *ctx)
  2084	{
  2085		struct damon_target *t, *next;
  2086	
  2087		damon_for_each_target_safe(t, next, ctx) {
  2088			if (ctx->ops.id == DAMON_OPS_VADDR ||
> 2089					ctx->ops.id == DAMON_OPS_FVADDR)
  2090				put_pid(t->pid);
  2091			damon_destroy_target(t);
  2092		}
  2093	}
  2094	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp