* [chanwoo:devfreq-testing 5/5] drivers/devfreq/governor_passive.c:409:2: error: use of undeclared identifier 'ret'
@ 2022-05-09 13:51 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-05-09 13:51 UTC (permalink / raw)
To: Chanwoo Choi; +Cc: llvm, kbuild-all, linux-pm
tree: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-testing
head: edb11683479cd9e51010f571ae4011ae01e88ee5
commit: edb11683479cd9e51010f571ae4011ae01e88ee5 [5/5] PM / devfreq: passive: Update frequency when start governor
config: arm64-randconfig-r034-20220509 (https://download.01.org/0day-ci/archive/20220509/202205092158.pfjjAl5S-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a385645b470e2d3a1534aae618ea56b31177639f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?id=edb11683479cd9e51010f571ae4011ae01e88ee5
git remote add chanwoo https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git
git fetch --no-tags chanwoo devfreq-testing
git checkout edb11683479cd9e51010f571ae4011ae01e88ee5
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/devfreq/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/devfreq/governor_passive.c:409:2: error: use of undeclared identifier 'ret'
ret = devfreq_update_target(devfreq, parent->previous_freq);
^
drivers/devfreq/governor_passive.c:410:6: error: use of undeclared identifier 'ret'
if (ret < 0)
^
drivers/devfreq/governor_passive.c:424:18: warning: unused variable 'parent' [-Wunused-variable]
struct devfreq *parent = (struct devfreq *)p_data->parent;
^
1 warning and 2 errors generated.
vim +/ret +409 drivers/devfreq/governor_passive.c
387
388 static int devfreq_passive_register_notifier(struct devfreq *devfreq)
389 {
390 struct devfreq_passive_data *p_data
391 = (struct devfreq_passive_data *)devfreq->data;
392 struct devfreq *parent = (struct devfreq *)p_data->parent;
393 struct notifier_block *nb = &p_data->nb;
394
395 if (!parent)
396 return -EPROBE_DEFER;
397
398 /*
399 * If the parent device changes the their frequency before
400 * registering the passive device, the passive device cannot
401 * receive the notification from parent device and then the
402 * passive device cannot be able to set the proper frequency
403 * according to the frequency of parent device.
404 *
405 * When start the passive governor, update the frequency
406 * according to the frequency of parent device.
407 */
408 mutex_lock(&devfreq->lock);
> 409 ret = devfreq_update_target(devfreq, parent->previous_freq);
410 if (ret < 0)
411 dev_warn(&devfreq->dev,
412 "failed to update devfreq using passive governor\n");
413 mutex_unlock(&devfreq->lock);
414
415 nb->notifier_call = devfreq_passive_notifier_call;
416 return devfreq_register_notifier(parent, nb, DEVFREQ_TRANSITION_NOTIFIER);
417 }
418
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-09 13:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-09 13:51 [chanwoo:devfreq-testing 5/5] drivers/devfreq/governor_passive.c:409:2: error: use of undeclared identifier 'ret' kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).