From: Tom Rix <trix@redhat.com>
To: arnd@arndb.de, gregkh@linuxfoundation.org, nathan@kernel.org,
ndesaulniers@google.com, ricky_wu@realtek.com,
kai.heng.feng@canonical.com
Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Tom Rix <trix@redhat.com>
Subject: [PATCH] misc: rtsx: Set setting_reg2 before use.
Date: Mon, 16 May 2022 09:00:47 -0400 [thread overview]
Message-ID: <20220516130047.3887590-1-trix@redhat.com> (raw)
The clang build fails with
rts5261.c:406:13: error: variable 'setting_reg2' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
} else if (efuse_valid == 0) {
^~~~~~~~~~~~~~~~
setting_reg2 is set in this block
if (efuse_valid == 2 || efuse_valid == 3) {
..
} else if (efuse_valid == 0) {
// default
..
}
But efuse_valid can also have a value of 1.
Change the 'else if' to 'else' to make the second block the default.
Fixes: b1c5f3085149 ("misc: rtsx: add rts5261 efuse function")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/misc/cardreader/rts5261.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c
index 749cc5a46d13..f22634b14dc8 100644
--- a/drivers/misc/cardreader/rts5261.c
+++ b/drivers/misc/cardreader/rts5261.c
@@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr)
setting_reg1 = PCR_SETTING_REG4;
setting_reg2 = PCR_SETTING_REG5;
}
- } else if (efuse_valid == 0) {
+ } else {
// default
setting_reg1 = PCR_SETTING_REG1;
setting_reg2 = PCR_SETTING_REG2;
--
2.27.0
next reply other threads:[~2022-05-16 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 13:00 Tom Rix [this message]
2022-05-16 15:56 ` [PATCH] misc: rtsx: Set setting_reg2 before use Nathan Chancellor
2022-05-16 17:06 ` Tom Rix
2022-05-16 21:22 ` Nick Desaulniers
2022-05-16 21:57 ` Nathan Chancellor
2022-05-17 1:53 ` Kai-Heng Feng
2022-05-17 8:10 ` Ricky WU
2022-05-19 20:57 ` Nathan Chancellor
2022-05-19 21:18 ` Tom Rix
2022-05-19 21:24 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516130047.3887590-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ricky_wu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox