From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A39762590; Mon, 23 May 2022 15:06:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88391C385A9; Mon, 23 May 2022 15:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653318417; bh=qiEZQ8DWEMoinQqoOyjtgxX3eAxznhmWe20hPy5hWDo=; h=From:To:Cc:Subject:Date:From; b=WX8r3XCacUsEACEbsEXvabZzEiI6ikeNhJdubv5QbwatsnStxS7Bwa0mKXtEDMP6l sqS2ZDMZIZey4KB9n2ugYkJg8JoKBOgA0uqb2OnI7ozeZeKXCd7nVfaktwaviaSXet zniWrTycVuR5sB54ZPi5QBiBWwqaRCKdFXXYekAggiRkTCXv3kAhzXRcPnMsQHCld7 4cjiL2Xd+m75YH4bo7l27rCDTJ6M37+giIs7INi6aLEshmUrTEemlal5jiyI3ofWNf s7GLxGivwij3RgDDGh+PO2PUBxP/rqbjjtSnwXfLC804ckIJxt5tlNVdc2WOUu/HTE I/uLpu0Rwii4g== From: Nathan Chancellor To: Arnd Bergmann , Greg Kroah-Hartman Cc: Nick Desaulniers , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, Nathan Chancellor , Dan Carpenter , kernel test robot , Tom Rix , Ricky WU Subject: [PATCH] misc: rtsx: Fix clang -Wsometimes-uninitialized in rts5261_init_from_hw() Date: Mon, 23 May 2022 08:05:22 -0700 Message-Id: <20220523150521.2947108-1-nathan@kernel.org> X-Mailer: git-send-email 2.36.1 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Clang warns: drivers/misc/cardreader/rts5261.c:406:13: error: variable 'setting_reg2' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] } else if (efuse_valid == 0) { ^~~~~~~~~~~~~~~~ drivers/misc/cardreader/rts5261.c:412:30: note: uninitialized use occurs here pci_read_config_dword(pdev, setting_reg2, &lval2); ^~~~~~~~~~~~ efuse_valid == 1 is not a valid value so just return early from the function to avoid using setting_reg2 uninitialized. Fixes: b1c5f3085149 ("misc: rtsx: add rts5261 efuse function") Reported-by: Dan Carpenter Reported-by: kernel test robot Reported-by: Tom Rix Suggested-by: Ricky WU Signed-off-by: Nathan Chancellor --- This is basically a v2 of https://lore.kernel.org/20220516130047.3887590-1-trix@redhat.com/. drivers/misc/cardreader/rts5261.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c index 749cc5a46d13..b1e76030cafd 100644 --- a/drivers/misc/cardreader/rts5261.c +++ b/drivers/misc/cardreader/rts5261.c @@ -407,6 +407,8 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr) // default setting_reg1 = PCR_SETTING_REG1; setting_reg2 = PCR_SETTING_REG2; + } else { + return; } pci_read_config_dword(pdev, setting_reg2, &lval2); base-commit: 90de6805267f8c79cd2b1a36805071e257c39b5c -- 2.36.1