Re: [PATCH 1/4] kvm: x86/pmu: Introduce masked events to the pmu event filter

Re: [PATCH 1/4] kvm: x86/pmu: Introduce masked events to the pmu event filter

[kernel test robot]

Hi Aaron,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kvm/master]
[also build test WARNING on v5.18]
[cannot apply to mst-vhost/linux-next next-20220523]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Aaron-Lewis/kvm-x86-pmu-Introduce-and-test-masked-events/20220524-054438
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git master
config: i386-randconfig-a011 (https://download.01.org/0day-ci/archive/20220524/202205241319.3YATdncf-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 10c9ecce9f6096e18222a331c5e7d085bd813f75)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f189a455a73825b7025d8feff486db18ebef171f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Aaron-Lewis/kvm-x86-pmu-Introduce-and-test-masked-events/20220524-054438
        git checkout f189a455a73825b7025d8feff486db18ebef171f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kvm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/x86/kvm/pmu.c:633:5: warning: no previous prototype for function 'has_invalid_event' [-Wmissing-prototypes]
   int has_invalid_event(struct kvm_pmu_event_filter *filter)
       ^
   arch/x86/kvm/pmu.c:633:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int has_invalid_event(struct kvm_pmu_event_filter *filter)
   ^
   static 
   1 warning generated.


vim +/has_invalid_event +633 arch/x86/kvm/pmu.c

   632	
 > 633	int has_invalid_event(struct kvm_pmu_event_filter *filter)
   634	{
   635		u64 event_mask;
   636		int i;
   637	
   638		event_mask = kvm_x86_ops.pmu_ops->get_event_mask(filter->flags);
   639		for(i = 0; i < filter->nevents; i++)
   640			if (filter->events[i] & ~event_mask)
   641				return true;
   642	
   643		return false;
   644	}
   645	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [PATCH 1/4] kvm: x86/pmu: Introduce masked events to the pmu event filter

[kernel test robot]

Hi Aaron,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kvm/master]
[also build test ERROR on v5.18]
[cannot apply to mst-vhost/linux-next next-20220524]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Aaron-Lewis/kvm-x86-pmu-Introduce-and-test-masked-events/20220524-054438
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git master
config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20220525/202205250725.AFgtAciB-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 10c9ecce9f6096e18222a331c5e7d085bd813f75)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f189a455a73825b7025d8feff486db18ebef171f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Aaron-Lewis/kvm-x86-pmu-Introduce-and-test-masked-events/20220524-054438
        git checkout f189a455a73825b7025d8feff486db18ebef171f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/x86/kvm/pmu.c:633:5: error: no previous prototype for function 'has_invalid_event' [-Werror,-Wmissing-prototypes]
   int has_invalid_event(struct kvm_pmu_event_filter *filter)
       ^
   arch/x86/kvm/pmu.c:633:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int has_invalid_event(struct kvm_pmu_event_filter *filter)
   ^
   static 
   1 error generated.


vim +/has_invalid_event +633 arch/x86/kvm/pmu.c

   632	
 > 633	int has_invalid_event(struct kvm_pmu_event_filter *filter)
   634	{
   635		u64 event_mask;
   636		int i;
   637	
   638		event_mask = kvm_x86_ops.pmu_ops->get_event_mask(filter->flags);
   639		for(i = 0; i < filter->nevents; i++)
   640			if (filter->events[i] & ~event_mask)
   641				return true;
   642	
   643		return false;
   644	}
   645	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp