Re: [RFC PATCH] riscv: Add Zawrs support for spinlocks

Re: [RFC PATCH] riscv: Add Zawrs support for spinlocks

[kernel test robot]

Hi Christoph,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on linus/master]
[cannot apply to v5.18]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Christoph-Muellner/riscv-Add-Zawrs-support-for-spinlocks/20220602-221228
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d1dc87763f406d4e67caf16dbe438a5647692395
config: riscv-randconfig-c006-20220605 (https://download.01.org/0day-ci/archive/20220605/202206050633.lWua2j70-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0a90b72c432d70aae035727ece4ba80ce820f381)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/8bacf50e3f136bfbce3e648e6f53443516125ba2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Christoph-Muellner/riscv-Add-Zawrs-support-for-spinlocks/20220602-221228
        git checkout 8bacf50e3f136bfbce3e648e6f53443516125ba2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash kernel/bpf/ kernel/futex/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/bpf/helpers.c:291:3: error: indirection requires pointer operand ('int' invalid)
                   atomic_cond_read_relaxed(l, !VAL);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/atomic.h:29:40: note: expanded from macro 'atomic_cond_read_relaxed'
   #define atomic_cond_read_relaxed(v, c) smp_cond_load_relaxed(&(v)->counter, (c))
                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/riscv/include/asm/barrier.h:144:10: note: expanded from macro 'smp_cond_load_relaxed'
                           VAL = __smp_load_reserved_relaxed(__PTR);       \
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/riscv/include/asm/barrier.h:88:2: note: expanded from macro '__smp_load_reserved_relaxed'
           compiletime_assert_atomic_lrsc_type(*ptr);                      \
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   note: (skipping 2 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/compiler_types.h:352:22: note: expanded from macro 'compiletime_assert'
           _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
           ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler_types.h:340:23: note: expanded from macro '_compiletime_assert'
           __compiletime_assert(condition, msg, prefix, suffix)
           ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler_types.h:332:9: note: expanded from macro '__compiletime_assert'
                   if (!(condition))                                       \
                         ^~~~~~~~~
   1 error generated.
--
>> kernel/futex/requeue.c:182:9: error: indirection requires pointer operand ('int' invalid)
                   (void)atomic_cond_read_relaxed(&q->requeue_state, VAL != Q_REQUEUE_PI_WAIT);
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/atomic.h:29:40: note: expanded from macro 'atomic_cond_read_relaxed'
   #define atomic_cond_read_relaxed(v, c) smp_cond_load_relaxed(&(v)->counter, (c))
                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/riscv/include/asm/barrier.h:144:10: note: expanded from macro 'smp_cond_load_relaxed'
                           VAL = __smp_load_reserved_relaxed(__PTR);       \
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/riscv/include/asm/barrier.h:88:2: note: expanded from macro '__smp_load_reserved_relaxed'
           compiletime_assert_atomic_lrsc_type(*ptr);                      \
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   note: (skipping 2 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/compiler_types.h:352:22: note: expanded from macro 'compiletime_assert'
           _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
           ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler_types.h:340:23: note: expanded from macro '_compiletime_assert'
           __compiletime_assert(condition, msg, prefix, suffix)
           ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler_types.h:332:9: note: expanded from macro '__compiletime_assert'
                   if (!(condition))                                       \
                         ^~~~~~~~~
   1 error generated.


vim +291 kernel/bpf/helpers.c

d83525ca62cf8e Alexei Starovoitov 2019-01-31  284  
d83525ca62cf8e Alexei Starovoitov 2019-01-31  285  static inline void __bpf_spin_lock(struct bpf_spin_lock *lock)
d83525ca62cf8e Alexei Starovoitov 2019-01-31  286  {
d83525ca62cf8e Alexei Starovoitov 2019-01-31  287  	atomic_t *l = (void *)lock;
d83525ca62cf8e Alexei Starovoitov 2019-01-31  288  
d83525ca62cf8e Alexei Starovoitov 2019-01-31  289  	BUILD_BUG_ON(sizeof(*l) != sizeof(*lock));
d83525ca62cf8e Alexei Starovoitov 2019-01-31  290  	do {
d83525ca62cf8e Alexei Starovoitov 2019-01-31 @291  		atomic_cond_read_relaxed(l, !VAL);
d83525ca62cf8e Alexei Starovoitov 2019-01-31  292  	} while (atomic_xchg(l, 1));
d83525ca62cf8e Alexei Starovoitov 2019-01-31  293  }
d83525ca62cf8e Alexei Starovoitov 2019-01-31  294  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp