From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Sedat Dilek <sedat.dilek@gmail.com>
Cc: Ian Rogers <irogers@google.com>,
llvm@lists.linux.dev, Fangrui Song <maskray@google.com>,
Sebastian Ullrich <sebasti@nullri.ch>
Subject: [PATCH] perf unwind: Fix uninitialized variable
Date: Mon, 6 Jun 2022 17:08:51 -0700 [thread overview]
Message-ID: <20220607000851.39798-1-irogers@google.com> (raw)
ret may be uninitialized on error goto paths.
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Fixes: dc2cf4ca866f ("perf unwind: Fix segbase for ld.lld linked objects")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/unwind-libunwind-local.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
index 37622699c91a..6e5b8cce47bf 100644
--- a/tools/perf/util/unwind-libunwind-local.c
+++ b/tools/perf/util/unwind-libunwind-local.c
@@ -174,7 +174,7 @@ static int elf_section_address_and_offset(int fd, const char *name, u64 *address
Elf *elf;
GElf_Ehdr ehdr;
GElf_Shdr shdr;
- int ret;
+ int ret = -1;
elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL);
if (elf == NULL)
--
2.36.1.255.ge46751e96f-goog
next reply other threads:[~2022-06-07 0:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 0:08 Ian Rogers [this message]
2022-06-07 0:26 ` [PATCH] perf unwind: Fix uninitialized variable Fangrui Song
2022-06-09 16:34 ` Arnaldo Carvalho de Melo
2022-06-07 18:12 ` Sedat Dilek
2022-06-08 19:29 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607000851.39798-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=maskray@google.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sebasti@nullri.ch \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox