* Re: [PATCH 2/2] dma-buf: Add an API for importing sync files (v10)
[not found] <20220608152142.14495-3-jason@jlekstrand.net>
@ 2022-06-08 23:34 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-06-08 23:34 UTC (permalink / raw)
To: Jason Ekstrand; +Cc: llvm, kbuild-all
Hi Jason,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tegra-drm/drm/tegra/for-next]
[cannot apply to drm-tip/drm-tip linus/master v5.19-rc1 next-20220608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Jason-Ekstrand/dma-buf-Add-an-API-for-exporting-sync-files-v15/20220608-232447
base: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
config: hexagon-randconfig-r041-20220608 (https://download.01.org/0day-ci/archive/20220609/202206090703.60i9pfJd-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/8bb6416c80c6e88769aa210e7042f4e39ba36e25
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jason-Ekstrand/dma-buf-Add-an-API-for-exporting-sync-files-v15/20220608-232447
git checkout 8bb6416c80c6e88769aa210e7042f4e39ba36e25
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/dma-buf/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/dma-buf/dma-buf.c:337:22: error: variable has incomplete type 'enum dma_resv_usage'
enum dma_resv_usage usage;
^
drivers/dma-buf/dma-buf.c:337:7: note: forward declaration of 'enum dma_resv_usage'
enum dma_resv_usage usage;
^
drivers/dma-buf/dma-buf.c:355:10: error: implicit declaration of function 'dma_resv_usage_rw' [-Werror,-Wimplicit-function-declaration]
usage = dma_resv_usage_rw(arg.flags & DMA_BUF_SYNC_WRITE);
^
drivers/dma-buf/dma-buf.c:356:8: error: implicit declaration of function 'dma_resv_get_singleton' [-Werror,-Wimplicit-function-declaration]
ret = dma_resv_get_singleton(dmabuf->resv, usage, &fence);
^
drivers/dma-buf/dma-buf.c:394:22: error: variable has incomplete type 'enum dma_resv_usage'
enum dma_resv_usage usage;
^
drivers/dma-buf/dma-buf.c:394:7: note: forward declaration of 'enum dma_resv_usage'
enum dma_resv_usage usage;
^
>> drivers/dma-buf/dma-buf.c:410:45: error: use of undeclared identifier 'DMA_RESV_USAGE_WRITE'
usage = (arg.flags & DMA_BUF_SYNC_WRITE) ? DMA_RESV_USAGE_WRITE :
^
>> drivers/dma-buf/dma-buf.c:411:10: error: use of undeclared identifier 'DMA_RESV_USAGE_READ'
DMA_RESV_USAGE_READ;
^
>> drivers/dma-buf/dma-buf.c:415:8: error: implicit declaration of function 'dma_resv_reserve_fences' [-Werror,-Wimplicit-function-declaration]
ret = dma_resv_reserve_fences(dmabuf->resv, 1);
^
drivers/dma-buf/dma-buf.c:415:8: note: did you mean 'dma_resv_reserve_shared'?
include/linux/dma-resv.h:458:5: note: 'dma_resv_reserve_shared' declared here
int dma_resv_reserve_shared(struct dma_resv *obj, unsigned int num_fences);
^
>> drivers/dma-buf/dma-buf.c:417:3: error: implicit declaration of function 'dma_resv_add_fence' [-Werror,-Wimplicit-function-declaration]
dma_resv_add_fence(dmabuf->resv, fence, usage);
^
8 errors generated.
vim +/DMA_RESV_USAGE_WRITE +410 drivers/dma-buf/dma-buf.c
331
332 #if IS_ENABLED(CONFIG_SYNC_FILE)
333 static long dma_buf_export_sync_file(struct dma_buf *dmabuf,
334 void __user *user_data)
335 {
336 struct dma_buf_export_sync_file arg;
337 enum dma_resv_usage usage;
338 struct dma_fence *fence = NULL;
339 struct sync_file *sync_file;
340 int fd, ret;
341
342 if (copy_from_user(&arg, user_data, sizeof(arg)))
343 return -EFAULT;
344
345 if (arg.flags & ~DMA_BUF_SYNC_RW)
346 return -EINVAL;
347
348 if ((arg.flags & DMA_BUF_SYNC_RW) == 0)
349 return -EINVAL;
350
351 fd = get_unused_fd_flags(O_CLOEXEC);
352 if (fd < 0)
353 return fd;
354
355 usage = dma_resv_usage_rw(arg.flags & DMA_BUF_SYNC_WRITE);
> 356 ret = dma_resv_get_singleton(dmabuf->resv, usage, &fence);
357 if (ret)
358 goto err_put_fd;
359
360 if (!fence)
361 fence = dma_fence_get_stub();
362
363 sync_file = sync_file_create(fence);
364
365 dma_fence_put(fence);
366
367 if (!sync_file) {
368 ret = -ENOMEM;
369 goto err_put_fd;
370 }
371
372 arg.fd = fd;
373 if (copy_to_user(user_data, &arg, sizeof(arg))) {
374 ret = -EFAULT;
375 goto err_put_file;
376 }
377
378 fd_install(fd, sync_file->file);
379
380 return 0;
381
382 err_put_file:
383 fput(sync_file->file);
384 err_put_fd:
385 put_unused_fd(fd);
386 return ret;
387 }
388
389 static long dma_buf_import_sync_file(struct dma_buf *dmabuf,
390 const void __user *user_data)
391 {
392 struct dma_buf_import_sync_file arg;
393 struct dma_fence *fence;
> 394 enum dma_resv_usage usage;
395 int ret = 0;
396
397 if (copy_from_user(&arg, user_data, sizeof(arg)))
398 return -EFAULT;
399
400 if (arg.flags & ~DMA_BUF_SYNC_RW)
401 return -EINVAL;
402
403 if ((arg.flags & DMA_BUF_SYNC_RW) == 0)
404 return -EINVAL;
405
406 fence = sync_file_get_fence(arg.fd);
407 if (!fence)
408 return -EINVAL;
409
> 410 usage = (arg.flags & DMA_BUF_SYNC_WRITE) ? DMA_RESV_USAGE_WRITE :
> 411 DMA_RESV_USAGE_READ;
412
413 dma_resv_lock(dmabuf->resv, NULL);
414
> 415 ret = dma_resv_reserve_fences(dmabuf->resv, 1);
416 if (!ret)
> 417 dma_resv_add_fence(dmabuf->resv, fence, usage);
418
419 dma_resv_unlock(dmabuf->resv);
420
421 dma_fence_put(fence);
422
423 return ret;
424 }
425 #endif
426
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread