Re: [PATCH 2/3] jump_label: mips: move module NOP patching into arch code

Re: [PATCH 2/3] jump_label: mips: move module NOP patching into arch code

[kernel test robot]

Hi Ard,

I love your patch! Yet something to improve:

[auto build test ERROR on s390/features]
[also build test ERROR on tip/x86/core vgupta-arc/for-next arm64/for-next/core deller-parisc/for-next linus/master v5.19-rc1 next-20220609]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Ard-Biesheuvel/jump_label-get-rid-of-NOP-patching-where-possible/20220608-184857
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: mips-rs90_defconfig (https://download.01.org/0day-ci/archive/20220610/202206100833.t7F1rrMU-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 971e13d69e3e7b687213fef22952be6a328c426c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mipsel-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/0f76bf7e2cda1943571bcfa08d52505950425ef8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ard-Biesheuvel/jump_label-get-rid-of-NOP-patching-where-possible/20220608-184857
        git checkout 0f76bf7e2cda1943571bcfa08d52505950425ef8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash arch/mips/kernel/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> arch/mips/kernel/jump_label.c:94:37: error: incomplete definition of type 'struct module'
           struct jump_entry *iter_start = mod->jump_entries;
                                           ~~~^
   include/linux/jump_label.h:196:8: note: forward declaration of 'struct module'
   struct module;
          ^
   arch/mips/kernel/jump_label.c:95:49: error: incomplete definition of type 'struct module'
           struct jump_entry *iter_stop = iter_start + mod->num_jump_entries;
                                                       ~~~^
   include/linux/jump_label.h:196:8: note: forward declaration of 'struct module'
   struct module;
          ^
>> arch/mips/kernel/jump_label.c:92:6: warning: no previous prototype for function 'jump_label_apply_nops' [-Wmissing-prototypes]
   void jump_label_apply_nops(struct module *mod)
        ^
   arch/mips/kernel/jump_label.c:92:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void jump_label_apply_nops(struct module *mod)
   ^
   static 
   1 warning and 2 errors generated.


vim +94 arch/mips/kernel/jump_label.c

    91	
  > 92	void jump_label_apply_nops(struct module *mod)
    93	{
  > 94		struct jump_entry *iter_start = mod->jump_entries;

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp