From: Miles Chen <miles.chen@mediatek.com>
To: <masahiroy@kernel.org>
Cc: <corbet@lwn.net>, <jonathanh@nvidia.com>,
<linux-doc@vger.kernel.org>, <linux-kbuild@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>,
<mpe@ellerman.id.au>, <nathan@kernel.org>,
<ndesaulniers@google.com>, <penguin-kernel@I-love.SAKURA.ne.jp>,
<trix@redhat.com>, <wangyugui@e16-tech.com>
Subject: Re: [PATCH v3] scripts/check-local-export: avoid 'wait $!' for process substitution
Date: Sat, 11 Jun 2022 00:57:24 +0800 [thread overview]
Message-ID: <20220610165724.16214-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220608011100.486735-1-masahiroy@kernel.org>
>Bash 4.4, released in 2016, supports 'wait $!' to check the exit status
>of a process substitution, but it seems too new.
>
>Some people using older bash versions (on CentOS 7, Ubuntu 16.04, etc.)
>reported an error like this:
>
> ./scripts/check-local-export: line 54: wait: pid 17328 is not a child of this shell
Thanks for fixing this!
I hit this issue and this patch fixes my problem.
Tested-by: Miles Chen <miles.chen@mediatek.com>
>
>I used the process substitution to avoid a pipeline, which executes each
>command in a subshell. If the while-loop is executed in the subshell
>context, variable changes within are lost after the subshell terminates.
prev parent reply other threads:[~2022-06-10 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 1:11 [PATCH v3] scripts/check-local-export: avoid 'wait $!' for process substitution Masahiro Yamada
2022-06-10 16:57 ` Miles Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610165724.16214-1-miles.chen@mediatek.com \
--to=miles.chen@mediatek.com \
--cc=corbet@lwn.net \
--cc=jonathanh@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=trix@redhat.com \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox