* Re: [PATCH v2 1/5] PM / devfreq: Fix cpufreq passive unregister erroring on PROBE_DEFER
[not found] <20220613134213.8904-2-ansuelsmth@gmail.com>
@ 2022-06-14 6:59 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-06-14 6:59 UTC (permalink / raw)
To: Christian 'Ansuel' Marangi, MyungJoo Ham, Kyungmin Park,
Chanwoo Choi, Sibi Sankar, Saravana Kannan, linux-pm,
linux-kernel
Cc: llvm, kbuild-all, Christian 'Ansuel' Marangi
Hi Christian,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on chanwoo/devfreq-testing]
[also build test ERROR on linus/master v5.19-rc2 next-20220610]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-Ansuel-Marangi/PM-devfreq-Various-Fixes-to-cpufreq-based-passive-governor/20220614-020616
base: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-testing
config: arm-randconfig-r026-20220613 (https://download.01.org/0day-ci/archive/20220614/202206141415.1BsuJvCD-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c97436f8b6e2718286e8496faf53a2c800e281cf)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/intel-lab-lkp/linux/commit/378807dd7da24162524c0ba84e996157b3e289c6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Christian-Ansuel-Marangi/PM-devfreq-Various-Fixes-to-cpufreq-based-passive-governor/20220614-020616
git checkout 378807dd7da24162524c0ba84e996157b3e289c6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/devfreq/governor_passive.c:235:72: error: too few arguments provided to function-like macro invocation
list_for_each_entry_safe(parent_cpu_data, &p_data->cpu_data_list, node) {
^
include/linux/list.h:760:9: note: macro 'list_for_each_entry_safe' defined here
#define list_for_each_entry_safe(pos, n, head, member) \
^
>> drivers/devfreq/governor_passive.c:235:2: error: use of undeclared identifier 'list_for_each_entry_safe'
list_for_each_entry_safe(parent_cpu_data, &p_data->cpu_data_list, node) {
^
2 errors generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
Depends on ARCH_SUSPEND_POSSIBLE
Selected by
- ARM_TEGRA_CPUIDLE && CPU_IDLE && (ARM || ARM64) && (ARCH_TEGRA || COMPILE_TEST && !ARM64 && MMU
- ARM_QCOM_SPM_CPUIDLE && CPU_IDLE && (ARM || ARM64) && (ARCH_QCOM || COMPILE_TEST && !ARM64 && MMU
vim +235 drivers/devfreq/governor_passive.c
220
221 static int cpufreq_passive_unregister_notifier(struct devfreq *devfreq)
222 {
223 struct devfreq_passive_data *p_data
224 = (struct devfreq_passive_data *)devfreq->data;
225 struct devfreq_cpu_data *parent_cpu_data;
226 int ret;
227
228 if (p_data->nb.notifier_call) {
229 ret = cpufreq_unregister_notifier(&p_data->nb,
230 CPUFREQ_TRANSITION_NOTIFIER);
231 if (ret < 0)
232 return ret;
233 }
234
> 235 list_for_each_entry_safe(parent_cpu_data, &p_data->cpu_data_list, node) {
236 list_del(&parent_cpu_data->node);
237
238 if (parent_cpu_data->opp_table)
239 dev_pm_opp_put_opp_table(parent_cpu_data->opp_table);
240
241 kfree(parent_cpu_data);
242 }
243
244 return 0;
245 }
246
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread