* Re: [PATCH v8 2/2] drm/msm/dp: clean up pixel_rate from dp_ctrl.c
[not found] <1655399361-10842-3-git-send-email-quic_khsieh@quicinc.com>
@ 2022-06-17 16:05 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-06-17 16:05 UTC (permalink / raw)
To: Kuogee Hsieh, dri-devel, robdclark, sean, swboyd, dianders, vkoul,
daniel, airlied, agross, dmitry.baryshkov, bjorn.andersson
Cc: llvm, kbuild-all, quic_sbillaka, linux-arm-msm, quic_abhinavk,
Kuogee Hsieh, quic_aravindh, freedreno, linux-kernel
Hi Kuogee,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on drm-exynos/exynos-drm-next]
[cannot apply to drm-intel/for-linux-next tegra-drm/drm/tegra/for-next airlied/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Kuogee-Hsieh/force-link-training-for-display-resolution-change/20220617-011110
base: git://anongit.freedesktop.org/drm/drm drm-next
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20220617/202206172356.J5CB8zDf-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project f0e608de27b3d568000046eebf3712ab542979d6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/b04f0b39a03a9fc3728e9414157f9d5f0b8b2366
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Kuogee-Hsieh/force-link-training-for-display-resolution-change/20220617-011110
git checkout b04f0b39a03a9fc3728e9414157f9d5f0b8b2366
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/msm/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:1587:5: warning: no previous prototype for function 'dp_ctrl_on_stream_phy_test_report' [-Wmissing-prototypes]
int dp_ctrl_on_stream_phy_test_report(struct dp_ctrl *dp_ctrl)
^
drivers/gpu/drm/msm/dp/dp_ctrl.c:1587:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int dp_ctrl_on_stream_phy_test_report(struct dp_ctrl *dp_ctrl)
^
static
1 warning generated.
vim +/dp_ctrl_on_stream_phy_test_report +1587 drivers/gpu/drm/msm/dp/dp_ctrl.c
1586
> 1587 int dp_ctrl_on_stream_phy_test_report(struct dp_ctrl *dp_ctrl)
1588 {
1589 int ret = 0;
1590 struct dp_ctrl_private *ctrl;
1591 unsigned long pixel_rate;
1592
1593 ctrl = container_of(dp_ctrl, struct dp_ctrl_private, dp_ctrl);
1594
1595 pixel_rate = ctrl->panel->dp_mode.drm_mode.clock;
1596 ret = dp_ctrl_enable_stream_clocks(ctrl, pixel_rate);
1597 if (ret) {
1598 DRM_ERROR("Failed to start pixel clocks. ret=%d\n", ret);
1599 return ret;
1600 }
1601
1602 dp_ctrl_send_phy_test_pattern(ctrl);
1603
1604 return 0;
1605 }
1606
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread