Re: [PATCH v1 net-next 3/6] af_unix: Define a per-netns hash table.

Re: [PATCH v1 net-next 3/6] af_unix: Define a per-netns hash table.

[kernel test robot]

Hi Kuniyuki,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220617-075046
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5dcb50c009c9f8ec1cfca6a81a05c0060a5bbf68
config: hexagon-randconfig-r045-20220617 (https://download.01.org/0day-ci/archive/20220618/202206180244.SIWZxbAo-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d764aa7fc6b9cc3fbe960019018f5f9e941eb0a6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/d0da436e1c42550dbd332f48fd11992d5f4af487
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220617-075046
        git checkout d0da436e1c42550dbd332f48fd11992d5f4af487
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/unix/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/unix/af_unix.c:3590:1: warning: unused label 'err_sysctl' [-Wunused-label]
   err_sysctl:
   ^~~~~~~~~~~
   1 warning generated.


vim +/err_sysctl +3590 net/unix/af_unix.c

  3573	
  3574		net->unx.hash = kmalloc(sizeof(struct unix_hashbucket) * UNIX_HASH_SIZE,
  3575					GFP_KERNEL);
  3576		if (!net->unx.hash)
  3577			goto err_proc;
  3578	
  3579		for (i = 0; i < UNIX_HASH_SIZE; i++) {
  3580			INIT_HLIST_HEAD(&net->unx.hash[i].head);
  3581			spin_lock_init(&net->unx.hash[i].lock);
  3582		}
  3583	
  3584		return 0;
  3585	
  3586	err_proc:
  3587	#ifdef CONFIG_PROC_FS
  3588		remove_proc_entry("unix", net->proc_net);
  3589	#endif
> 3590	err_sysctl:
  3591		unix_sysctl_unregister(net);
  3592	out:
  3593		return -ENOMEM;
  3594	}
  3595	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [PATCH v1 net-next 3/6] af_unix: Define a per-netns hash table.

[Kuniyuki Iwashima]

From:   kernel test robot <lkp@intel.com>
Date:   Sat, 18 Jun 2022 02:17:44 +0800
> Hi Kuniyuki,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on net-next/master]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220617-075046
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5dcb50c009c9f8ec1cfca6a81a05c0060a5bbf68
> config: hexagon-randconfig-r045-20220617 (https://download.01.org/0day-ci/archive/20220618/202206180244.SIWZxbAo-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d764aa7fc6b9cc3fbe960019018f5f9e941eb0a6)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/d0da436e1c42550dbd332f48fd11992d5f4af487
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220617-075046
>         git checkout d0da436e1c42550dbd332f48fd11992d5f4af487
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/unix/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> net/unix/af_unix.c:3590:1: warning: unused label 'err_sysctl' [-Wunused-label]
>    err_sysctl:
>    ^~~~~~~~~~~
>    1 warning generated.
> 
> 
> vim +/err_sysctl +3590 net/unix/af_unix.c
> 
>   3573	
>   3574		net->unx.hash = kmalloc(sizeof(struct unix_hashbucket) * UNIX_HASH_SIZE,
>   3575					GFP_KERNEL);
>   3576		if (!net->unx.hash)
>   3577			goto err_proc;
>   3578	
>   3579		for (i = 0; i < UNIX_HASH_SIZE; i++) {
>   3580			INIT_HLIST_HEAD(&net->unx.hash[i].head);
>   3581			spin_lock_init(&net->unx.hash[i].lock);
>   3582		}
>   3583	
>   3584		return 0;
>   3585	
>   3586	err_proc:
>   3587	#ifdef CONFIG_PROC_FS
>   3588		remove_proc_entry("unix", net->proc_net);
>   3589	#endif
> > 3590	err_sysctl:

I will move this label into the #ifdef CONFIG_PROC_FS block above.

Thanks!


>   3591		unix_sysctl_unregister(net);
>   3592	out:
>   3593		return -ENOMEM;
>   3594	}
>   3595	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://01.org/lkp