From: Nancy.Lin <nancy.lin@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
<wim@linux-watchdog.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>, <linux@roeck-us.net>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
"Nathan Chancellor" <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"Nancy . Lin" <nancy.lin@mediatek.com>,
"jason-jh . lin" <jason-jh.lin@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<dri-devel@lists.freedesktop.org>, <llvm@lists.linux.dev>,
<singo.chang@mediatek.com>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v23 07/14] drm/mediatek: add display merge async reset control
Date: Mon, 20 Jun 2022 17:19:23 +0800 [thread overview]
Message-ID: <20220620091930.27797-8-nancy.lin@mediatek.com> (raw)
In-Reply-To: <20220620091930.27797-1-nancy.lin@mediatek.com>
Add merge async reset control in mtk_merge_stop. Async hw doesn't do self
reset on each sof signal(start of frame), so need to reset the async to
clear the hw status for the next merge start.
Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tested-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_disp_merge.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_merge.c b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
index 2e13d2fb429e..6428b6203ffe 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_merge.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
@@ -8,6 +8,7 @@
#include <linux/of_device.h>
#include <linux/of_irq.h>
#include <linux/platform_device.h>
+#include <linux/reset.h>
#include <linux/soc/mediatek/mtk-cmdq.h>
#include "mtk_drm_ddp_comp.h"
@@ -67,6 +68,7 @@ struct mtk_disp_merge {
struct cmdq_client_reg cmdq_reg;
bool fifo_en;
bool mute_support;
+ struct reset_control *reset_ctl;
};
void mtk_merge_start(struct device *dev)
@@ -101,6 +103,9 @@ void mtk_merge_stop_cmdq(struct device *dev, struct cmdq_pkt *cmdq_pkt)
mtk_ddp_write(cmdq_pkt, 0, &priv->cmdq_reg, priv->regs,
DISP_REG_MERGE_CTRL);
+
+ if (priv->async_clk)
+ reset_control_reset(priv->reset_ctl);
}
static void mtk_merge_fifo_setting(struct mtk_disp_merge *priv,
@@ -264,6 +269,12 @@ static int mtk_disp_merge_probe(struct platform_device *pdev)
return PTR_ERR(priv->async_clk);
}
+ if (priv->async_clk) {
+ priv->reset_ctl = devm_reset_control_get_optional_exclusive(dev, NULL);
+ if (IS_ERR(priv->reset_ctl))
+ return PTR_ERR(priv->reset_ctl);
+ }
+
#if IS_REACHABLE(CONFIG_MTK_CMDQ)
ret = cmdq_dev_get_client_reg(dev, &priv->cmdq_reg, 0);
if (ret)
--
2.18.0
next prev parent reply other threads:[~2022-06-20 9:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 9:19 [PATCH v23 00/14] Add MediaTek SoC DRM (vdosys1) support for mt8195 Nancy.Lin
2022-06-20 9:19 ` [PATCH v23 01/14] dt-bindings: mediatek: add vdosys1 RDMA definition " Nancy.Lin
2022-06-22 3:55 ` CK Hu
2022-06-28 1:28 ` CK Hu
2022-06-20 9:19 ` [PATCH v23 02/14] dt-bindings: mediatek: add ethdr " Nancy.Lin
2022-06-20 9:19 ` [PATCH v23 03/14] drm/mediatek: add display MDP RDMA support for MT8195 Nancy.Lin
2022-06-28 1:34 ` CK Hu
2022-06-20 9:19 ` [PATCH v23 04/14] drm/mediatek: add display merge advance config API " Nancy.Lin
2022-06-28 1:32 ` CK Hu
2022-06-20 9:19 ` [PATCH v23 05/14] drm/mediatek: add display merge start/stop API for cmdq support Nancy.Lin
2022-06-28 1:35 ` CK Hu
2022-06-20 9:19 ` [PATCH v23 06/14] drm/mediatek: add display merge mute/unmute support for MT8195 Nancy.Lin
2022-06-28 1:37 ` CK Hu
2022-06-20 9:19 ` Nancy.Lin [this message]
2022-06-28 1:39 ` [PATCH v23 07/14] drm/mediatek: add display merge async reset control CK Hu
2022-06-20 9:19 ` [PATCH v23 08/14] drm/mediatek: add ETHDR support for MT8195 Nancy.Lin
2022-06-20 9:19 ` [PATCH v23 09/14] drm/mediatek: add mediatek-drm plane color encoding info Nancy.Lin
2022-06-28 1:42 ` CK Hu
2022-06-20 9:19 ` [PATCH v23 10/14] drm/mediatek: add ovl_adaptor support for MT8195 Nancy.Lin
2022-06-20 9:19 ` [PATCH v23 11/14] drm/mediatek: add dma dev get function Nancy.Lin
2022-06-20 9:19 ` [PATCH v23 12/14] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support Nancy.Lin
2022-06-20 9:19 ` [PATCH v23 13/14] drm/mediatek: add drm ovl_adaptor sub driver for MT8195 Nancy.Lin
2022-06-20 9:19 ` [PATCH v23 14/14] drm/mediatek: add mediatek-drm of vdosys1 support " Nancy.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620091930.27797-8-nancy.lin@mediatek.com \
--to=nancy.lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=singo.chang@mediatek.com \
--cc=wim@linux-watchdog.org \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox