* [PATCH] ASoC: codecs: wsa883x: fix fallthrough error
@ 2022-07-01 15:59 Tom Rix
2022-07-01 21:57 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2022-07-01 15:59 UTC (permalink / raw)
To: srinivas.kandagatla, bgoswami, lgirdwood, broonie, perex, tiwai,
nathan, ndesaulniers
Cc: alsa-devel, linux-kernel, llvm, Tom Rix
clang build fails with
sound/soc/codecs/wsa883x.c:1207:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
default:
Add the missing break.
Fixes: cdb09e623143 ("ASoC: codecs: wsa883x: add control, dapm widgets and map")
Signed-off-by: Tom Rix <trix@redhat.com>
---
sound/soc/codecs/wsa883x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c
index 40c7d64a9c41..dcd88175b9cd 100644
--- a/sound/soc/codecs/wsa883x.c
+++ b/sound/soc/codecs/wsa883x.c
@@ -1204,6 +1204,7 @@ static int wsa883x_spkr_event(struct snd_soc_dapm_widget *w,
WSA883X_SPKR_PWM_FREQ_F300KHZ);
snd_soc_component_write_field(component, WSA883X_DRE_CTL_0,
WSA883X_DRE_PROG_DELAY_MASK, 0x9);
+ break;
default:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: codecs: wsa883x: fix fallthrough error
2022-07-01 15:59 [PATCH] ASoC: codecs: wsa883x: fix fallthrough error Tom Rix
@ 2022-07-01 21:57 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-07-01 21:57 UTC (permalink / raw)
To: Tom Rix
Cc: srinivas.kandagatla, bgoswami, lgirdwood, perex, tiwai, nathan,
ndesaulniers, alsa-devel, linux-kernel, llvm
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
On Fri, Jul 01, 2022 at 11:59:30AM -0400, Tom Rix wrote:
> clang build fails with
> sound/soc/codecs/wsa883x.c:1207:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
> default:
Thanks but I already applied a patch for this from Srinivas.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-01 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-01 15:59 [PATCH] ASoC: codecs: wsa883x: fix fallthrough error Tom Rix
2022-07-01 21:57 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox