From: kernel test robot <lkp@intel.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
ilpo.jarvinen@linux.intel.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
andriy.shevchenko@linux.intel.com, vz@mleia.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
lukas@wunner.de, p.rosenberger@kunbus.com,
Lino Sanfilippo <l.sanfilippo@kunbus.com>
Subject: Re: [PATCH v3 3/8] serial: core, 8250: set RS485 termination gpio in serial core
Date: Mon, 11 Jul 2022 00:07:51 +0800 [thread overview]
Message-ID: <202207102355.Y27cvu6y-lkp@intel.com> (raw)
In-Reply-To: <20220710150322.2846170-4-LinoSanfilippo@gmx.de>
Hi Lino,
I love your patch! Perhaps something to improve:
[auto build test WARNING on 7e5b4322cde067e1d0f1bf8f490e93f664a7c843]
url: https://github.com/intel-lab-lkp/linux/commits/Lino-Sanfilippo/Fixes-and-cleanup-for-RS485/20220710-230624
base: 7e5b4322cde067e1d0f1bf8f490e93f664a7c843
config: hexagon-randconfig-r041-20220710 (https://download.01.org/0day-ci/archive/20220710/202207102355.Y27cvu6y-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6ce63e267aab79ca87bf63453d34dd3909ab978d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/846f02e6da9692810ed632dd72f45af667c3cc67
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Lino-Sanfilippo/Fixes-and-cleanup-for-RS485/20220710-230624
git checkout 846f02e6da9692810ed632dd72f45af667c3cc67
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/tty/serial/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/tty/serial/serial_core.c:1364:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
if (!rs485->flags & SER_RS485_ENABLED)
^ ~
drivers/tty/serial/serial_core.c:1364:6: note: add parentheses after the '!' to evaluate the bitwise operator first
if (!rs485->flags & SER_RS485_ENABLED)
^
( )
drivers/tty/serial/serial_core.c:1364:6: note: add parentheses around left hand side expression to silence this warning
if (!rs485->flags & SER_RS485_ENABLED)
^
( )
1 warning generated.
vim +1364 drivers/tty/serial/serial_core.c
1360
1361 static void uart_set_rs485_termination(struct uart_port *port,
1362 const struct serial_rs485 *rs485)
1363 {
> 1364 if (!rs485->flags & SER_RS485_ENABLED)
1365 return;
1366
1367 gpiod_set_value_cansleep(port->rs485_term_gpio,
1368 !!(rs485->flags & SER_RS485_TERMINATE_BUS));
1369 }
1370
--
0-DAY CI Kernel Test Service
https://01.org/lkp
parent reply other threads:[~2022-07-10 16:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220710150322.2846170-4-LinoSanfilippo@gmx.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207102355.Y27cvu6y-lkp@intel.com \
--to=lkp@intel.com \
--cc=LinoSanfilippo@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=lukas@wunner.de \
--cc=p.rosenberger@kunbus.com \
--cc=robh+dt@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox