Re: [PATCH v25 07/10] soc: mediatek: mmsys: add mmsys for support 64 reset bits

Nancy.Lin
2022-08-19T04:13:30Z

Hi Nicolas,

On Fri, 2022-08-19 at 10:09 +0800, Nancy.Lin wrote:
> Hi Nicolas,
>
> Thanks for the review.
>
> On Thu, 2022-08-18 at 17:47 -0400, Nícolas F. R. A. Prado wrote:
> > Hi Nancy,
> >
> > On Mon, Jul 11, 2022 at 03:52:42PM +0800, Nancy.Lin wrote:
> > [..]
> > > static const struct mtk_mmsys_driver_data
> > > mt2701_mmsys_driver_data
> > > = {
> > > .clk_driver = "clk-mt2701-mm",
> > > .routes = mmsys_default_routing_table,
> > > @@ -86,6 +88,7 @@ static const struct mtk_mmsys_driver_data
> > > mt8173_mmsys_driver_data = {
> > > .routes = mmsys_default_routing_table,
> > > .num_routes = ARRAY_SIZE(mmsys_default_routing_table),
> > > .sw0_rst_offset = MT8183_MMSYS_SW0_RST_B,
> > > + .num_resets = 32,
> > > };
> > >
> > > static const struct mtk_mmsys_match_data mt8173_mmsys_match_data
> > > =
> > > {
> > > @@ -100,6 +103,7 @@ static const struct mtk_mmsys_driver_data
> > > mt8183_mmsys_driver_data = {
> > > .routes = mmsys_mt8183_routing_table,
> > > .num_routes = ARRAY_SIZE(mmsys_mt8183_routing_table),
> > > .sw0_rst_offset = MT8183_MMSYS_SW0_RST_B,
> > > + .num_resets = 32,
> > > };
> > >
> > > static const struct mtk_mmsys_match_data mt8183_mmsys_match_data
> > > =
> > > {
> > > @@ -114,6 +118,7 @@ static const struct mtk_mmsys_driver_data
> > > mt8186_mmsys_driver_data = {
> > > .routes = mmsys_mt8186_routing_table,
> > > .num_routes = ARRAY_SIZE(mmsys_mt8186_routing_table),
> > > .sw0_rst_offset = MT8186_MMSYS_SW0_RST_B,
> > > + .num_resets = 32,
> > > };
> >
> > [..]
> > > @@ -351,18 +362,6 @@ static int mtk_mmsys_probe(struct
> > > platform_device *pdev)
> > > return ret;
> > > }
> > >
> > > - spin_lock_init(&mmsys->lock);
> > > -
> > > - mmsys->rcdev.owner = THIS_MODULE;
> > > - mmsys->rcdev.nr_resets = 32;
> >
> > The number of resets was previously always set to 32, and now
> > you're
> > instead
> > setting it based on num_resets from each machine. The issue is,
> > you're
> > forgetting a bunch of them.
> >
> > mt8192 didn't get a num_reset, so this commit breaks the display on
> > mt8192 based
> > devices. But mt8192 isn't the only one, there are other platforms
> > missing this
> > property. Please set num_resets to 32 in every single one of them,
> > otherwise
> > there will be display regressions.
> >
> > Thanks,
> > Nícolas
>
> It's my mistake. I will set num_resets to 32 for every mmsys driver.
>
> Thanks,
> Nancy

After review the code, I think only the mmsys driver with the
sw0_rst_offset setting should set num_resets to 32, otherwise it would
set wrong addr in the mtk_mmsys_reset_update() function. Those mmsys
without sw0_rst_offset set should not set num_resets to 32.

Thanks,
Nancy