* Re: [RFC PATCH mptcp-next v4] mptcp: Fast Open Mechanism
[not found] <20220801024656.397714-1-dmytro@shytyi.net>
@ 2022-08-01 14:44 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-08-01 14:44 UTC (permalink / raw)
To: Dmytro SHYTYI; +Cc: llvm, kbuild-all
Hi Dmytro,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on mptcp/export]
[cannot apply to linus/master v5.19 next-20220728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Dmytro-SHYTYI/mptcp-Fast-Open-Mechanism/20220801-104819
base: https://github.com/multipath-tcp/mptcp_net-next.git export
config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220801/202208012231.LBppAj4q-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 52cd00cabf479aa7eb6dbb063b7ba41ea57bce9e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6222c0fe0b73c1e72446173527266777f4ffe855
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Dmytro-SHYTYI/mptcp-Fast-Open-Mechanism/20220801-104819
git checkout 6222c0fe0b73c1e72446173527266777f4ffe855
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/ipv4/tcp_output.c:186:3: warning: result of comparison of constant -1 with expression of type 'u8' (aka 'unsigned char') is always false [-Wtautological-constant-out-of-range-compare]
NET_ADD_STATS(sock_net(sk), LINUX_MIB_TCPACKCOMPRESSED,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/net/ip.h:293:41: note: expanded from macro 'NET_ADD_STATS'
#define NET_ADD_STATS(net, field, adnd) SNMP_ADD_STATS((net)->mib.net_statistics, field, adnd)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/net/snmp.h:143:4: note: expanded from macro 'SNMP_ADD_STATS'
this_cpu_add(mib->mibs[field], addend)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:509:33: note: expanded from macro 'this_cpu_add'
#define this_cpu_add(pcp, val) __pcpu_size_call(this_cpu_add_, pcp, val)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
<scratch space>:186:1: note: expanded from here
this_cpu_add_8
^
arch/x86/include/asm/percpu.h:326:35: note: expanded from macro 'this_cpu_add_8'
#define this_cpu_add_8(pcp, val) percpu_add_op(8, volatile, (pcp), val)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/percpu.h:127:31: note: expanded from macro 'percpu_add_op'
((val) == 1 || (val) == -1)) ? \
~~~~~ ^ ~~
>> net/ipv4/tcp_output.c:747:54: error: too many arguments to function call, expected 3, have 4
if (mptcp_synack_options(req, &size, &opts->mptcp, &opts->options)) {
~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~
include/net/mptcp.h:249:20: note: 'mptcp_synack_options' declared here
static inline bool mptcp_synack_options(const struct request_sock *req,
^
1 warning and 1 error generated.
vim +747 net/ipv4/tcp_output.c
739
740 static void mptcp_set_option_cond(const struct request_sock *req,
741 struct tcp_out_options *opts,
742 unsigned int *remaining)
743 {
744 if (rsk_is_mptcp(req)) {
745 unsigned int size;
746
> 747 if (mptcp_synack_options(req, &size, &opts->mptcp, &opts->options)) {
748 if (*remaining >= size) {
749 opts->options |= OPTION_MPTCP;
750 *remaining -= size;
751 }
752 }
753 }
754 }
755
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread