Re: [PATCH] thunderbolt: thunderbolt: add vendor's NVM formats

kernel test robot
2022-08-07T09:40:32Z

Hi Szuying,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.19 next-20220805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Szuying-Chen/thunderbolt-thunderbolt-add-vendor-s-NVM-formats/20220805-172732
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b2a88c212e652e94f1e4b635910972ac57ba4e97
config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20220807/202208071758.wZC5VHIZ-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 26dd42705c2af0b8f6e5d6cdb32c9bd5ed9524eb)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/cc64350d27db3b30e5ceef2b5d6a3c48b9a4d989
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Szuying-Chen/thunderbolt-thunderbolt-add-vendor-s-NVM-formats/20220805-172732
git checkout cc64350d27db3b30e5ceef2b5d6a3c48b9a4d989
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/thunderbolt/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/thunderbolt/nvm.c:75:3: error: expected expression
struct tb_nvm *nvm;
^
drivers/thunderbolt/nvm.c:79:3: error: use of undeclared identifier 'nvm'
nvm = tb_nvm_alloc(&sw->dev);
^
drivers/thunderbolt/nvm.c:80:14: error: use of undeclared identifier 'nvm'
if (IS_ERR(nvm)) {
^
drivers/thunderbolt/nvm.c:81:18: error: use of undeclared identifier 'nvm'
ret = PTR_ERR(nvm);
^
drivers/thunderbolt/nvm.c:89:3: error: use of undeclared identifier 'nvm'
nvm->vendor.date = (((u8)val) << 0x10 | ((u8)(val >> 0x8)) << 0x8 | (u8)(val >> 0x10));
^
drivers/thunderbolt/nvm.c:94:3: error: use of undeclared identifier 'nvm'
nvm->vendor.customerID = (((u8)val) << 0x8 | ((u8)(val >> 0x8)));
^
drivers/thunderbolt/nvm.c:95:3: error: use of undeclared identifier 'nvm'
nvm->vendor.version = (u8)(val >> 0x10);
^
drivers/thunderbolt/nvm.c:97:27: error: use of undeclared identifier 'nvm'
ret = tb_nvm_add_active(nvm, nvm_size, tb_switch_nvm_read);
^
drivers/thunderbolt/nvm.c:101:31: error: use of undeclared identifier 'nvm'
ret = tb_nvm_add_non_active(nvm, NVM_MAX_SIZE, tb_switch_nvm_write);
^
drivers/thunderbolt/nvm.c:105:13: error: use of undeclared identifier 'nvm'
sw->nvm = nvm;
^
drivers/thunderbolt/nvm.c:109:3: error: expected expression
unsigned int image_size;
^
drivers/thunderbolt/nvm.c:116:3: error: use of undeclared identifier 'image_size'
image_size = sw->nvm->buf_data_size;
^
drivers/thunderbolt/nvm.c:117:7: error: use of undeclared identifier 'image_size'; did you mean 'page_size'?
if (image_size < NVM_MIN_SIZE || image_size > NVM_MAX_SIZE) {
^~~~~~~~~~
page_size
include/linux/mm.h:927:29: note: 'page_size' declared here
static inline unsigned long page_size(struct page *page)
^
drivers/thunderbolt/nvm.c:117:36: error: use of undeclared identifier 'image_size'; did you mean 'page_size'?
if (image_size < NVM_MIN_SIZE || image_size > NVM_MAX_SIZE) {
^~~~~~~~~~
page_size
include/linux/mm.h:927:29: note: 'page_size' declared here
static inline unsigned long page_size(struct page *page)
^
drivers/thunderbolt/nvm.c:121:43: error: use of undeclared identifier 'image_size'; did you mean 'page_size'?
ret = usb4_switch_nvm_write(sw, 0, buf, image_size);
^~~~~~~~~~
page_size
include/linux/mm.h:927:29: note: 'page_size' declared here
static inline unsigned long page_size(struct page *page)
^
>> drivers/thunderbolt/nvm.c:76:7: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]
u32 val;
^
1 warning and 15 errors generated.

vim +76 drivers/thunderbolt/nvm.c

62
63 static int tb_nvm_vendor_apply(struct tb_switch *sw, unsigned int handle)
64 {
65 int ret = 0;
66
67 switch (handle) {
68 case 0:
69 if (sw->no_nvm_upgrade)
70 sw->no_nvm_upgrade = false;
71
72 break;
73
74 case 1:
75 struct tb_nvm *nvm;
> 76 u32 val;
77 u32 nvm_size;
78
79 nvm = tb_nvm_alloc(&sw->dev);
80 if (IS_ERR(nvm)) {
81 ret = PTR_ERR(nvm);
82 break;
83 }
84
85 ret = usb4_switch_nvm_read(sw, NVM_Date, &val, sizeof(val));
86 if (ret)
87 break;
88
89 nvm->vendor.date = (((u8)val) << 0x10 | ((u8)(val >> 0x8)) << 0x8 | (u8)(val >> 0x10));
90 ret = usb4_switch_nvm_read(sw, NVM_CUSTOMER_ID, &val, sizeof(val));
91 if (ret)
92 break;
93
94 nvm->vendor.customerID = (((u8)val) << 0x8 | ((u8)(val >> 0x8)));
95 nvm->vendor.version = (u8)(val >> 0x10);
96 nvm_size = SZ_512K;
97 ret = tb_nvm_add_active(nvm, nvm_size, tb_switch_nvm_read);
98 if (ret)
99 break;
100
101 ret = tb_nvm_add_non_active(nvm, NVM_MAX_SIZE, tb_switch_nvm_write);
102 if (ret)
103 break;
104
105 sw->nvm = nvm;
106 break;
107
108 case 2:
109 unsigned int image_size;
110 const u8 *buf = sw->nvm->buf;
111
112 if (!buf) {
113 ret = -EINVAL;
114 break;
115 }
116 image_size = sw->nvm->buf_data_size;
117 if (image_size < NVM_MIN_SIZE || image_size > NVM_MAX_SIZE) {
118 ret = -EINVAL;
119 break;
120 }
121 ret = usb4_switch_nvm_write(sw, 0, buf, image_size);
122 if (!ret)
123 sw->nvm->flushed = true;
124
125 break;
126
127 default:
128 break;
129 }
130
131 if ((handle == 1) && (ret != 0))
132 tb_nvm_free(sw->nvm);
133
134 return ret;
135 }
136

--
0-DAY CI Kernel Test Service