* [PATCH] scripts/Makefile.extrawarn: Do not disable clang's -Wformat-zero-length
@ 2022-08-10 23:01 Nathan Chancellor
2022-08-17 14:44 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2022-08-10 23:01 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Nick Desaulniers, Tom Rix, linux-kbuild, linux-kernel, llvm,
Nathan Chancellor
There are no instances of this warning in the tree across several
difference architectures and configurations. This was added by
commit 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
back in 2014, where it might have been necessary, but there are no
instances of it now so stop disabling it to increase warning coverage
for clang.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
| 1 -
1 file changed, 1 deletion(-)
--git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 9bbaf7112a9b..69cec45c4e71 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -48,7 +48,6 @@ else
ifdef CONFIG_CC_IS_CLANG
KBUILD_CFLAGS += -Wno-initializer-overrides
KBUILD_CFLAGS += -Wno-sign-compare
-KBUILD_CFLAGS += -Wno-format-zero-length
KBUILD_CFLAGS += $(call cc-disable-warning, pointer-to-enum-cast)
KBUILD_CFLAGS += -Wno-tautological-constant-out-of-range-compare
KBUILD_CFLAGS += $(call cc-disable-warning, unaligned-access)
base-commit: aeb6e6ac18c73ec287b3b1e2c913520699358c13
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scripts/Makefile.extrawarn: Do not disable clang's -Wformat-zero-length
2022-08-10 23:01 [PATCH] scripts/Makefile.extrawarn: Do not disable clang's -Wformat-zero-length Nathan Chancellor
@ 2022-08-17 14:44 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2022-08-17 14:44 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Nick Desaulniers, Tom Rix, Linux Kbuild mailing list,
Linux Kernel Mailing List, clang-built-linux
On Thu, Aug 11, 2022 at 8:01 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> There are no instances of this warning in the tree across several
> difference architectures and configurations. This was added by
> commit 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
> back in 2014, where it might have been necessary, but there are no
> instances of it now so stop disabling it to increase warning coverage
> for clang.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
Applied to linux-kbuild/fixes. Thanks.
> scripts/Makefile.extrawarn | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index 9bbaf7112a9b..69cec45c4e71 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -48,7 +48,6 @@ else
> ifdef CONFIG_CC_IS_CLANG
> KBUILD_CFLAGS += -Wno-initializer-overrides
> KBUILD_CFLAGS += -Wno-sign-compare
> -KBUILD_CFLAGS += -Wno-format-zero-length
> KBUILD_CFLAGS += $(call cc-disable-warning, pointer-to-enum-cast)
> KBUILD_CFLAGS += -Wno-tautological-constant-out-of-range-compare
> KBUILD_CFLAGS += $(call cc-disable-warning, unaligned-access)
>
> base-commit: aeb6e6ac18c73ec287b3b1e2c913520699358c13
> --
> 2.37.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-17 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-10 23:01 [PATCH] scripts/Makefile.extrawarn: Do not disable clang's -Wformat-zero-length Nathan Chancellor
2022-08-17 14:44 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox