* Re: [PATCH 1/2] USB: core: add a way to revoke access to open USB devices
[not found] <20220809094300.83116-2-hadess@hadess.net>
@ 2022-08-10 17:18 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-08-10 17:18 UTC (permalink / raw)
To: Bastien Nocera, linux-usb, bpf
Cc: llvm, kbuild-all, Greg Kroah-Hartman, Alan Stern,
Benjamin Tissoires, Peter Hutterer, Eric W . Biederman,
Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Bastien Nocera
Hi Bastien,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on balbi-usb/testing/next peter-chen-usb/for-usb-next linus/master v5.19 next-20220810]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bastien-Nocera/USB-core-add-a-way-to-revoke-access-to-open-USB-devices/20220809-174609
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: arm64-randconfig-r001-20220810 (https://download.01.org/0day-ci/archive/20220811/202208110108.ilG9Ea14-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/6bd6f04e6d463be82fbf45585e4af84925bf1ab9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Bastien-Nocera/USB-core-add-a-way-to-revoke-access-to-open-USB-devices/20220809-174609
git checkout 6bd6f04e6d463be82fbf45585e4af84925bf1ab9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/usb/core/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/usb/core/devio.c:2649:1: warning: unused label 'out' [-Wunused-label]
out:
^~~~
1 warning generated.
vim +/out +2649 drivers/usb/core/devio.c
2627
2628 int usb_revoke_for_euid(struct usb_device *udev,
2629 int euid)
2630 {
2631 struct usb_dev_state *ps;
2632
2633 usb_lock_device(udev);
2634
2635 list_for_each_entry(ps, &udev->filelist, list) {
2636 if (euid >= 0) {
2637 kuid_t kuid;
2638
2639 if (!ps || !ps->cred)
2640 continue;
2641 kuid = ps->cred->euid;
2642 if (kuid.val != euid)
2643 continue;
2644 }
2645
2646 usbdev_revoke(ps);
2647 }
2648
> 2649 out:
2650 usb_unlock_device(udev);
2651 return 0;
2652 }
2653
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread