Re: [PATCH v4 3/4] fanotify,audit: Allow audit to use the full permission event response

Re: [PATCH v4 3/4] fanotify,audit: Allow audit to use the full permission event response

[kernel test robot]

Hi Richard,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jack-fs/fsnotify]
[also build test WARNING on pcmoore-audit/next linus/master v5.19 next-20220810]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Richard-Guy-Briggs/fanotify-Allow-user-space-to-pass-back-additional-audit-info/20220810-012825
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify
config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220811/202208110406.Lb3ONrcP-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/bee8cac0b7796a753948c83b403a152f8c6acb8c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Richard-Guy-Briggs/fanotify-Allow-user-space-to-pass-back-additional-audit-info/20220810-012825
        git checkout bee8cac0b7796a753948c83b403a152f8c6acb8c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/auditsc.c:2907:8: warning: variable 'ib' set but not used [-Wunused-but-set-variable]
           char *ib = buf;
                 ^
   1 warning generated.


vim +/ib +2907 kernel/auditsc.c

  2902	
  2903	void __audit_fanotify(u32 response, size_t len, char *buf)
  2904	{
  2905		struct fanotify_response_info_audit_rule *friar;
  2906		size_t c = len;
> 2907		char *ib = buf;
  2908	
  2909		if (!(len && buf)) {
  2910			audit_log(audit_context(), GFP_KERNEL, AUDIT_FANOTIFY,
  2911				  "resp=%u fan_type=0 fan_info=?", response);
  2912			return;
  2913		}
  2914		while (c >= sizeof(struct fanotify_response_info_header)) {
  2915			friar = (struct fanotify_response_info_audit_rule *)buf;
  2916			switch (friar->hdr.type) {
  2917			case FAN_RESPONSE_INFO_AUDIT_RULE:
  2918				if (friar->hdr.len < sizeof(*friar)) {
  2919					audit_log(audit_context(), GFP_KERNEL, AUDIT_FANOTIFY,
  2920						  "resp=%u fan_type=%u fan_info=(incomplete)",
  2921						  response, friar->hdr.type);
  2922					return;
  2923				}
  2924				audit_log(audit_context(), GFP_KERNEL, AUDIT_FANOTIFY,
  2925					  "resp=%u fan_type=%u fan_info=%u",
  2926					  response, friar->hdr.type, friar->audit_rule);
  2927			}
  2928			c -= friar->hdr.len;
  2929			ib += friar->hdr.len;
  2930		}
  2931	}
  2932	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp