From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C38C46A8 for ; Thu, 11 Aug 2022 18:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660242516; x=1691778516; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3fA3slRt3QaRDvpFlIyp4A4gcmLnDPb+Je+ZzpvKXpM=; b=lohwRiwF/THstQfrcAW2LdQHC7uad+IpLCK8+fwGNENK82KSpyRD4WSc xCne89zA0Unv6b5AiWzwrIaq3PRDsKveKId7dhCvxDh1bxbBkhLEQh077 zn321cGtuCbBhOospOTHxx9Lt1LcaW063Fculy4Ly9WamWtrNx62fswfV +/tqUc9gfhhprMsKr7m2qfAJarCShpYKZp7FJKC0walRuT7Pyn5Vnjz/R RCuhoTepJcN7kWz4sn7Z4Y/BKP+OTkQxnoq+uABJeE45XRmrWXaU2EO2V rHj2rgjPSha5j/ZPriG/+Wzs4muE4oAYlpUy+CR+E2Zfqoctodyi+sKcN g==; X-IronPort-AV: E=McAfee;i="6400,9594,10436"; a="317395121" X-IronPort-AV: E=Sophos;i="5.93,230,1654585200"; d="scan'208";a="317395121" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2022 11:28:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,230,1654585200"; d="scan'208";a="673799075" Received: from lkp-server02.sh.intel.com (HELO cfab306db114) ([10.239.97.151]) by fmsmga004.fm.intel.com with ESMTP; 11 Aug 2022 11:28:01 -0700 Received: from kbuild by cfab306db114 with local (Exim 4.96) (envelope-from ) id 1oMCuW-0000VP-13; Thu, 11 Aug 2022 18:28:00 +0000 Date: Fri, 12 Aug 2022 02:27:48 +0800 From: kernel test robot To: menglong8.dong@gmail.com, kuba@kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, ojeda@kernel.org, ndesaulniers@google.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, asml.silence@gmail.com, imagedong@tencent.com, luiz.von.dentz@intel.com, vasily.averin@linux.dev, jk@codeconstruct.com.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: skb: prevent the split of kfree_skb_reason() by gcc Message-ID: <202208120238.cz3RvV74-lkp@intel.com> References: <20220811120708.34912-1-imagedong@tencent.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220811120708.34912-1-imagedong@tencent.com> Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/menglong8-dong-gmail-com/net-skb-prevent-the-split-of-kfree_skb_reason-by-gcc/20220811-200919 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f86d1fbbe7858884d6754534a0afbb74fc30bc26 config: riscv-randconfig-r042-20220811 (https://download.01.org/0day-ci/archive/20220812/202208120238.cz3RvV74-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/8e014b654d9e51abed132155237d855b25da06a0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review menglong8-dong-gmail-com/net-skb-prevent-the-split-of-kfree_skb_reason-by-gcc/20220811-200919 git checkout 8e014b654d9e51abed132155237d855b25da06a0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash net/core/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> net/core/skbuff.c:780:6: warning: unknown attribute 'optimize' ignored [-Wunknown-attributes] void __nofnsplit ^~~~~~~~~~~ include/linux/compiler_attributes.h:374:56: note: expanded from macro '__nofnsplit' #define __nofnsplit __attribute__((optimize("O1"))) ^~~~~~~~~~~~~~ 1 warning generated. vim +/optimize +780 net/core/skbuff.c 770 771 /** 772 * kfree_skb_reason - free an sk_buff with special reason 773 * @skb: buffer to free 774 * @reason: reason why this skb is dropped 775 * 776 * Drop a reference to the buffer and free it if the usage count has 777 * hit zero. Meanwhile, pass the drop reason to 'kfree_skb' 778 * tracepoint. 779 */ > 780 void __nofnsplit 781 kfree_skb_reason(struct sk_buff *skb, enum skb_drop_reason reason) 782 { 783 if (!skb_unref(skb)) 784 return; 785 786 DEBUG_NET_WARN_ON_ONCE(reason <= 0 || reason >= SKB_DROP_REASON_MAX); 787 788 trace_kfree_skb(skb, __builtin_return_address(0), reason); 789 __kfree_skb(skb); 790 } 791 EXPORT_SYMBOL(kfree_skb_reason); 792 -- 0-DAY CI Kernel Test Service https://01.org/lkp