Re: [PATCH] blk-wbt: do not throttle swap write on processes other than kswapd

Re: [PATCH] blk-wbt: do not throttle swap write on processes other than kswapd

[kernel test robot]

Hi Hongchen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v5.19 next-20220811]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hongchen-Zhang/blk-wbt-do-not-throttle-swap-write-on-processes-other-than-kswapd/20220811-193652
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: arm-randconfig-r001-20220811 (https://download.01.org/0day-ci/archive/20220812/202208120245.VvjRBGkd-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/a3ed95d0b72fa83c2ad007bee31d928fad40e70d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hongchen-Zhang/blk-wbt-do-not-throttle-swap-write-on-processes-other-than-kswapd/20220811-193652
        git checkout a3ed95d0b72fa83c2ad007bee31d928fad40e70d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> block/blk-wbt.c:558:26: error: use of undeclared identifier 'end_swap_bio_write'
                       (bio->bi_end_io != end_swap_bio_write))
                                          ^
   1 error generated.


vim +/end_swap_bio_write +558 block/blk-wbt.c

   542	
   543	static enum wbt_flags bio_to_wbt_flags(struct rq_wb *rwb, struct bio *bio)
   544	{
   545		enum wbt_flags flags = 0;
   546	
   547		if (!rwb_enabled(rwb))
   548			return 0;
   549	
   550		if (bio_op(bio) == REQ_OP_READ) {
   551			flags = WBT_READ;
   552		} else if (wbt_should_throttle(bio)) {
   553			if (current_is_kswapd())
   554				flags |= WBT_KSWAPD;
   555			if (bio_op(bio) == REQ_OP_DISCARD)
   556				flags |= WBT_DISCARD;
   557			if (current_is_kswapd() ||
 > 558			    (bio->bi_end_io != end_swap_bio_write))
   559				flags |= WBT_TRACKED;
   560		}
   561		return flags;
   562	}
   563	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp