From: Ian Rogers <irogers@google.com>
To: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Tom Rix" <trix@redhat.com>,
"Athira Rajeev" <atrajeev@linux.vnet.ibm.com>,
"Weiguo Li" <liwg06@foxmail.com>,
"Pavithra Gurushankar" <gpavithrasha@gmail.com>,
"Thomas Richter" <tmricht@linux.ibm.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Dario Petrillo" <dario.pk1@gmail.com>,
"Wenyu Liu" <liuwenyu7@huawei.com>,
Hewenliang <hewenliang4@huawei.com>,
yaowenbin <yaowenbin1@huawei.com>,
"Dave Marchevsky" <davemarchevsky@fb.com>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Alexandre Truong" <alexandre.truong@arm.com>,
"Kim Phillips" <kim.phillips@amd.com>,
"Leo Yan" <leo.yan@linaro.org>,
"Quentin Monnet" <quentin@isovalent.com>,
"William Cohen" <wcohen@redhat.com>,
"Andres Freund" <andres@anarazel.de>,
"Song Liu" <songliubraving@fb.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Martin Liška" <mliska@suse.cz>,
"Colin Ian King" <colin.king@intel.com>,
"James Clark" <james.clark@arm.com>,
"Fangrui Song" <maskray@google.com>,
"Stephane Eranian" <eranian@google.com>,
"Kajol Jain" <kjain@linux.ibm.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Alexey Bayduraev" <alexey.v.bayduraev@linux.intel.com>,
"Riccardo Mancini" <rickyman7@gmail.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Zechuan Chen" <chenzechuan1@huawei.com>,
"Jason Wang" <wangborong@cdjrlc.com>,
"Lexi Shao" <shaolexi@huawei.com>,
"Remi Bernon" <rbernon@codeweavers.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
llvm@lists.linux.dev
Cc: Ian Rogers <irogers@google.com>
Subject: [PATCH v1 0/6] Mutex wrapper, locking and memory leak fixes
Date: Tue, 16 Aug 2022 22:39:24 -0700 [thread overview]
Message-ID: <20220817053930.769840-1-irogers@google.com> (raw)
When fixing a locking race and memory leak in:
https://lore.kernel.org/linux-perf-users/20211118193714.2293728-1-irogers@google.com/
It was requested that debug mutex code be separated out into its own
files. This was done by Pavithra Gurushankar in:
https://lore.kernel.org/lkml/20220727111954.105118-1-gpavithrasha@gmail.com/
These patches fix issues with the previous patches, add in the
original dso->nsinfo fix and then build on our mutex wrapper with
clang's -Wthread-safety analysis. The analysis found missing unlocks
in builtin-sched.c which are fixed and -Wthread-safety is enabled by
default when building with clang.
Ian Rogers (4):
perf dso: Hold lock when accessing nsinfo
perf mutex: Add thread safety annotations
perf mutex: Fix thread safety analysis
perf build: Enable -Wthread-safety with clang
Pavithra Gurushankar (2):
perf mutex: Wrapped usage of mutex and cond
perf mutex: Update use of pthread mutex/cond
tools/perf/Makefile.config | 5 +
tools/perf/bench/epoll-ctl.c | 33 +++----
tools/perf/bench/epoll-wait.c | 33 +++----
tools/perf/bench/futex-hash.c | 33 +++----
tools/perf/bench/futex-lock-pi.c | 33 +++----
tools/perf/bench/futex-requeue.c | 33 +++----
tools/perf/bench/futex-wake-parallel.c | 33 +++----
tools/perf/bench/futex-wake.c | 33 +++----
tools/perf/bench/numa.c | 93 +++++++-----------
tools/perf/builtin-inject.c | 4 +
tools/perf/builtin-lock.c | 1 -
tools/perf/builtin-record.c | 13 ++-
tools/perf/builtin-sched.c | 75 ++++++++-------
tools/perf/builtin-top.c | 45 ++++-----
tools/perf/tests/mmap-basic.c | 2 -
tools/perf/tests/openat-syscall-all-cpus.c | 2 +-
tools/perf/tests/perf-record.c | 2 -
tools/perf/ui/browser.c | 20 ++--
tools/perf/ui/browsers/annotate.c | 12 +--
tools/perf/ui/setup.c | 5 +-
tools/perf/ui/tui/helpline.c | 5 +-
tools/perf/ui/tui/progress.c | 8 +-
tools/perf/ui/tui/setup.c | 8 +-
tools/perf/ui/tui/util.c | 18 ++--
tools/perf/ui/ui.h | 4 +-
tools/perf/util/Build | 1 +
tools/perf/util/annotate.c | 15 +--
tools/perf/util/annotate.h | 4 +-
tools/perf/util/bpf-event.h | 1 -
tools/perf/util/build-id.c | 12 ++-
tools/perf/util/dso.c | 19 ++--
tools/perf/util/dso.h | 4 +-
tools/perf/util/hist.c | 6 +-
tools/perf/util/hist.h | 4 +-
tools/perf/util/map.c | 3 +
tools/perf/util/mmap.h | 1 -
tools/perf/util/mutex.c | 99 +++++++++++++++++++
tools/perf/util/mutex.h | 105 +++++++++++++++++++++
tools/perf/util/probe-event.c | 3 +
tools/perf/util/symbol.c | 4 +-
tools/perf/util/top.h | 5 +-
41 files changed, 529 insertions(+), 310 deletions(-)
create mode 100644 tools/perf/util/mutex.c
create mode 100644 tools/perf/util/mutex.h
--
2.37.1.595.g718a3a8f04-goog
next reply other threads:[~2022-08-17 5:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 5:39 Ian Rogers [this message]
2022-08-17 5:39 ` [PATCH v1 1/6] perf mutex: Wrapped usage of mutex and cond Ian Rogers
2022-08-17 5:39 ` [PATCH v1 2/6] perf mutex: Update use of pthread mutex/cond Ian Rogers
2022-08-17 11:54 ` Arnaldo Carvalho de Melo
2022-08-17 13:16 ` Ian Rogers
2022-08-17 13:50 ` Arnaldo Carvalho de Melo
2022-08-17 18:49 ` Arnaldo Carvalho de Melo
2022-08-17 20:42 ` Ian Rogers
2022-08-17 5:39 ` [PATCH v1 3/6] perf dso: Hold lock when accessing nsinfo Ian Rogers
2022-08-17 5:39 ` [PATCH v1 4/6] perf mutex: Add thread safety annotations Ian Rogers
2022-08-17 5:39 ` [PATCH v1 5/6] perf mutex: Fix thread safety analysis Ian Rogers
2022-08-18 16:41 ` Namhyung Kim
2022-08-18 18:17 ` Ian Rogers
2022-08-19 6:42 ` Namhyung Kim
2022-08-17 5:39 ` [PATCH v1 6/6] perf build: Enable -Wthread-safety with clang Ian Rogers
2022-08-18 6:11 ` Namhyung Kim
2022-08-18 13:17 ` Ian Rogers
2022-08-18 15:59 ` Namhyung Kim
2022-08-18 16:20 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817053930.769840-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.truong@arm.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=andrealmeid@igalia.com \
--cc=andres@anarazel.de \
--cc=andrii@kernel.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=chenzechuan1@huawei.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=colin.king@intel.com \
--cc=dario.pk1@gmail.com \
--cc=dave@stgolabs.net \
--cc=davemarchevsky@fb.com \
--cc=dvhart@infradead.org \
--cc=eranian@google.com \
--cc=gpavithrasha@gmail.com \
--cc=hewenliang4@huawei.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kim.phillips@amd.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liuwenyu7@huawei.com \
--cc=liwg06@foxmail.com \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=maskray@google.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=ravi.bangoria@amd.com \
--cc=rbernon@codeweavers.com \
--cc=rickyman7@gmail.com \
--cc=shaolexi@huawei.com \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=tmricht@linux.ibm.com \
--cc=trix@redhat.com \
--cc=wangborong@cdjrlc.com \
--cc=wcohen@redhat.com \
--cc=yaowenbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox