From: kernel test robot <lkp@intel.com>
To: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf-next] netfilter: remove NFPROTO_DECNET
Date: Tue, 23 Aug 2022 09:16:42 +0800 [thread overview]
Message-ID: <202208230953.khEWYODC-lkp@intel.com> (raw)
In-Reply-To: <20220822144121.22026-1-fw@strlen.de>
Hi Florian,
I love your patch! Yet something to improve:
[auto build test ERROR on nf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Florian-Westphal/netfilter-remove-NFPROTO_DECNET/20220822-224303
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: hexagon-randconfig-r041-20220821 (https://download.01.org/0day-ci/archive/20220823/202208230953.khEWYODC-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project abce7acebd4c06c977bc4bd79170697f1122bc5e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0776a7974c60171c4c1322add934ecc73273f538
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Florian-Westphal/netfilter-remove-NFPROTO_DECNET/20220822-224303
git checkout 0776a7974c60171c4c1322add934ecc73273f538
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/decnet/ net/netfilter/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from net/decnet/af_decnet.c:109:
>> include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
case NFPROTO_DECNET:
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
1 error generated.
--
In file included from net/decnet/dn_nsp_in.c:64:
In file included from include/uapi/linux/netfilter_decnet.h:11:
>> include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
case NFPROTO_DECNET:
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
>> net/decnet/dn_nsp_in.c:808:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_LOCAL_IN,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
2 errors generated.
--
In file included from net/decnet/dn_route.c:69:
In file included from include/uapi/linux/netfilter_decnet.h:11:
>> include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
case NFPROTO_DECNET:
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
>> net/decnet/dn_route.c:567:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_PRE_ROUTING,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
net/decnet/dn_route.c:595:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_PRE_ROUTING,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
net/decnet/dn_route.c:700:19: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_HELLO,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
net/decnet/dn_route.c:706:19: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_ROUTE,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
net/decnet/dn_route.c:710:19: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_HELLO,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
net/decnet/dn_route.c:715:19: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_HELLO,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
net/decnet/dn_route.c:765:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_LOCAL_OUT,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
net/decnet/dn_route.c:812:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_FORWARD,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
9 errors generated.
--
In file included from net/decnet/dn_neigh.c:37:
In file included from include/uapi/linux/netfilter_decnet.h:11:
>> include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
case NFPROTO_DECNET:
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
>> net/decnet/dn_neigh.c:250:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_POST_ROUTING,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
net/decnet/dn_neigh.c:291:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_POST_ROUTING,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
net/decnet/dn_neigh.c:333:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
return NF_HOOK(NFPROTO_DECNET, NF_DN_POST_ROUTING,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
4 errors generated.
--
In file included from net/netfilter/core.c:10:
>> include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
case NFPROTO_DECNET:
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
>> net/netfilter/core.c:304:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
case NFPROTO_DECNET:
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
2 errors generated.
--
In file included from net/decnet/netfilter/dn_rtmsg.c:18:
>> include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
case NFPROTO_DECNET:
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
>> net/decnet/netfilter/dn_rtmsg.c:118:9: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'?
.pf = NFPROTO_DECNET,
^~~~~~~~~~~~~~
NFPROTO_INET
include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here
NFPROTO_INET = 1,
^
2 errors generated.
vim +247 include/linux/netfilter.h
af4610c39589d8 Florian Westphal 2016-02-25 225
e3b37f11e6e4e6 Aaron Conole 2016-09-21 226 rcu_read_lock();
b0f38338aef2da Florian Westphal 2017-12-03 227 switch (pf) {
b0f38338aef2da Florian Westphal 2017-12-03 228 case NFPROTO_IPV4:
b0f38338aef2da Florian Westphal 2017-12-03 229 hook_head = rcu_dereference(net->nf.hooks_ipv4[hook]);
b0f38338aef2da Florian Westphal 2017-12-03 230 break;
b0f38338aef2da Florian Westphal 2017-12-03 231 case NFPROTO_IPV6:
b0f38338aef2da Florian Westphal 2017-12-03 232 hook_head = rcu_dereference(net->nf.hooks_ipv6[hook]);
b0f38338aef2da Florian Westphal 2017-12-03 233 break;
b0f38338aef2da Florian Westphal 2017-12-03 234 case NFPROTO_ARP:
2a95183a5e0375 Florian Westphal 2017-12-07 235 #ifdef CONFIG_NETFILTER_FAMILY_ARP
421c119f558761 Florian Westphal 2018-09-24 236 if (WARN_ON_ONCE(hook >= ARRAY_SIZE(net->nf.hooks_arp)))
421c119f558761 Florian Westphal 2018-09-24 237 break;
b0f38338aef2da Florian Westphal 2017-12-03 238 hook_head = rcu_dereference(net->nf.hooks_arp[hook]);
2a95183a5e0375 Florian Westphal 2017-12-07 239 #endif
b0f38338aef2da Florian Westphal 2017-12-03 240 break;
b0f38338aef2da Florian Westphal 2017-12-03 241 case NFPROTO_BRIDGE:
2a95183a5e0375 Florian Westphal 2017-12-07 242 #ifdef CONFIG_NETFILTER_FAMILY_BRIDGE
b0f38338aef2da Florian Westphal 2017-12-03 243 hook_head = rcu_dereference(net->nf.hooks_bridge[hook]);
2a95183a5e0375 Florian Westphal 2017-12-07 244 #endif
b0f38338aef2da Florian Westphal 2017-12-03 245 break;
bb4badf3a3dc81 Florian Westphal 2017-12-07 246 #if IS_ENABLED(CONFIG_DECNET)
b0f38338aef2da Florian Westphal 2017-12-03 @247 case NFPROTO_DECNET:
b0f38338aef2da Florian Westphal 2017-12-03 248 hook_head = rcu_dereference(net->nf.hooks_decnet[hook]);
b0f38338aef2da Florian Westphal 2017-12-03 249 break;
bb4badf3a3dc81 Florian Westphal 2017-12-07 250 #endif
b0f38338aef2da Florian Westphal 2017-12-03 251 default:
b0f38338aef2da Florian Westphal 2017-12-03 252 WARN_ON_ONCE(1);
b0f38338aef2da Florian Westphal 2017-12-03 253 break;
b0f38338aef2da Florian Westphal 2017-12-03 254 }
b0f38338aef2da Florian Westphal 2017-12-03 255
e3b37f11e6e4e6 Aaron Conole 2016-09-21 256 if (hook_head) {
107a9f4dc9211c David Miller 2015-04-05 257 struct nf_hook_state state;
cfdfab314647b1 David S. Miller 2015-04-03 258
01886bd91f1ba4 Pablo Neira Ayuso 2016-11-03 259 nf_hook_state_init(&state, hook, pf, indev, outdev,
1610a73c4175e7 Pablo Neira Ayuso 2016-11-03 260 sk, net, okfn);
fe72926b792e52 Florian Westphal 2016-09-21 261
960632ece6949b Aaron Conole 2017-08-24 262 ret = nf_hook_slow(skb, &state, hook_head, 0);
e3b37f11e6e4e6 Aaron Conole 2016-09-21 263 }
fe72926b792e52 Florian Westphal 2016-09-21 264 rcu_read_unlock();
e3b37f11e6e4e6 Aaron Conole 2016-09-21 265
fe72926b792e52 Florian Westphal 2016-09-21 266 return ret;
cfdfab314647b1 David S. Miller 2015-04-03 267 }
16a6677fdf1d11 Patrick McHardy 2006-01-06 268
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next parent reply other threads:[~2022-08-23 1:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220822144121.22026-1-fw@strlen.de>
2022-08-23 1:16 ` kernel test robot [this message]
2022-08-23 10:06 ` [PATCH nf-next] netfilter: remove NFPROTO_DECNET kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208230953.khEWYODC-lkp@intel.com \
--to=lkp@intel.com \
--cc=fw@strlen.de \
--cc=kbuild-all@lists.01.org \
--cc=llvm@lists.linux.dev \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox