From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A46028E2 for ; Tue, 23 Aug 2022 21:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661288406; x=1692824406; h=date:from:to:cc:subject:message-id:mime-version; bh=BvgCsSust8dBjobMdB4ImhqeP5fOpG+9LXmDqL3hvEA=; b=h+nqq6iKl6mP8gCKSTESv/8dZtRfSonWsmVXyPssyHI1cbe6sQmn5QyL OMpmvKYfTmuHU2y4JYc84uMjLK6g3D8a/e1mt6sZKBq+3rcot3hGPjjRD JaOzu7uLDDTp4uPseKze3AINJcJubSUhY42EXNh4A/jz1ir3FcTT0PsLF 0zXUxBPcX3PPDqoLG/vSo5Ph+Zz18PXquvmOR/I/D/UlNh3eEmt0TbB4C nWeff+hSFfsnimG9VdCa1BLgBJJbFEJyXptjYxVQhXNH+mWNpv2k8aW0A qs4zmz1QYQo5f3DeeVtQcJr5FeokkhQvBiwj1N3E8LiQYRCHLVI6Nybqz Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10448"; a="295076477" X-IronPort-AV: E=Sophos;i="5.93,258,1654585200"; d="scan'208";a="295076477" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 14:00:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,258,1654585200"; d="scan'208";a="937621494" Received: from lkp-server02.sh.intel.com (HELO 9bbcefcddf9f) ([10.239.97.151]) by fmsmga005.fm.intel.com with ESMTP; 23 Aug 2022 14:00:04 -0700 Received: from kbuild by 9bbcefcddf9f with local (Exim 4.96) (envelope-from ) id 1oQb0F-0000Xj-1i; Tue, 23 Aug 2022 21:00:03 +0000 Date: Wed, 24 Aug 2022 04:59:58 +0800 From: kernel test robot To: Leon Romanovsky Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Raed Salem , Huy Nguyen Subject: [leon-rdma:xfrm-next 4/34] net/xfrm/xfrm_device.c:383:49: warning: '&&' within '||' Message-ID: <202208240416.Q0XLEKCM-lkp@intel.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git xfrm-next head: a3d3cb4010b4294c2c6a60d398dd417f335982f3 commit: d7b5afa45594beb1a60cba94c0e9e2b645c6a881 [4/34] xfrm: add TX datapath support for IPsec full offload mode config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220824/202208240416.Q0XLEKCM-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/commit/?id=d7b5afa45594beb1a60cba94c0e9e2b645c6a881 git remote add leon-rdma https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git git fetch --no-tags leon-rdma xfrm-next git checkout d7b5afa45594beb1a60cba94c0e9e2b645c6a881 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/xfrm/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> net/xfrm/xfrm_device.c:383:49: warning: '&&' within '||' [-Wlogical-op-parentheses] (!dev || (dev == xfrm_dst_path(dst)->dev)) && !xdst->child->xfrm) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ net/xfrm/xfrm_device.c:383:49: note: place parentheses around the '&&' expression to silence this warning (!dev || (dev == xfrm_dst_path(dst)->dev)) && !xdst->child->xfrm) { ^ ( ) 1 warning generated. vim +383 net/xfrm/xfrm_device.c 371 372 bool xfrm_dev_offload_ok(struct sk_buff *skb, struct xfrm_state *x) 373 { 374 int mtu; 375 struct dst_entry *dst = skb_dst(skb); 376 struct xfrm_dst *xdst = (struct xfrm_dst *)dst; 377 struct net_device *dev = x->xso.dev; 378 379 if (!x->type_offload || x->encap) 380 return false; 381 382 if (x->xso.type == XFRM_DEV_OFFLOAD_FULL || > 383 (!dev || (dev == xfrm_dst_path(dst)->dev)) && !xdst->child->xfrm) { 384 mtu = xfrm_state_mtu(x, xdst->child_mtu_cached); 385 if (skb->len <= mtu) 386 goto ok; 387 388 if (skb_is_gso(skb) && skb_gso_validate_network_len(skb, mtu)) 389 goto ok; 390 } 391 392 return false; 393 394 ok: 395 if (dev && dev->xfrmdev_ops && dev->xfrmdev_ops->xdo_dev_offload_ok) 396 return x->xso.dev->xfrmdev_ops->xdo_dev_offload_ok(skb, x); 397 398 return true; 399 } 400 EXPORT_SYMBOL_GPL(xfrm_dev_offload_ok); 401 -- 0-DAY CI Kernel Test Service https://01.org/lkp